Preparing migration to @dooboo-ui/theme #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujonglee
added
🚽 migration
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 94.63% 94.86% +0.23%
==========================================
Files 27 28 +1
Lines 652 682 +30
Branches 285 306 +21
==========================================
+ Hits 617 647 +30
Misses 35 35 |
2 tasks
hyochan
added a commit
that referenced
this pull request
Oct 16, 2021
This is a follow-up to previous work #149 . * initial docs migration * demo migration init * Fix broken tests except [ButtonGroup] * Update CI * Fix [ButtonGroup] test Co-authored-by: hyochan <dooboolab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before migrating to
@dooboo-ui/theme, I clean up existingtheme-related code, and apply default theme.After this PR, the only thing left for migration is to change
{ThemeProvider, useTheme, withTheme}'s import path fromsrc/main/themeto@dooboo-ui/themeTest Plan
none.
Related Issues
#104, #105, #129
Tests
Just update snapshot for
Accordion. But no output changed.Checklist
yarn test:alland make sure nothing fails. You can runyarn test -uto update snapshots if needed.