Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Improve a signIn function to validate a email & password correctly #436

Closed
DevYuns opened this issue Jul 27, 2021 · 1 comment
Closed

Improve a signIn function to validate a email & password correctly #436

DevYuns opened this issue Jul 27, 2021 · 1 comment
Labels
1️⃣ good first issue Good for newcomers

Comments

@DevYuns
Copy link
Contributor

DevYuns commented Jul 27, 2021

Specify project
Is this Client issue or Server side issue?

client

Describe the bug

When try to log in with email and password, signIn function can not validate email. That means if I write wrong email or make a typos, It just show a password error message. So I didn't know what's wrong whether email or password.

To Reproduce
Steps to reproduce the behavior:

  1. Write a email with typos
  2. Write a correct password
  3. then click signIn button,
  4. It just show me a password error message, even though I write a correct password.

Expected behavior
A clear and concise description of what you expected to happen.

When I write a wrong email address, It should give me a email error feedback.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@hyochan hyochan added the 1️⃣ good first issue Good for newcomers label Jul 28, 2021
@hyochan
Copy link
Owner

hyochan commented Jul 28, 2021

The error message for signIn should not be as kind as other errors for security issues. They are going to be really useful for the attackers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1️⃣ good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants