Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Graphql server migration on client side #147

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Jun 30, 2020

Specify project

Client

Description

Due to migrationon server-side, I've managed to sync the client project with new graphql server.

Tests

Base relay tests

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan force-pushed the migration/hackatalkserver-transfer branch from e417b7e to 675d6f1 Compare June 30, 2020 12:17
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #147 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   66.39%   66.30%   -0.10%     
==========================================
  Files          22       22              
  Lines         372      371       -1     
  Branches       25       25              
==========================================
- Hits          247      246       -1     
  Misses        119      119              
  Partials        6        6              
Impacted Files Coverage Δ
server/src/types/models/User.ts 92.85% <100.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82a63a...50fb5e8. Read the comment docs.

@hyochan
Copy link
Owner Author

hyochan commented Jun 30, 2020

@smallbee3 I hope you to check out this typing problem with me.
image

Hope this can be figured out if possible. This is in client/src/App.tsx

@hyochan hyochan merged commit 6dfa69d into master Jun 30, 2020
@hyochan hyochan deleted the migration/hackatalkserver-transfer branch June 30, 2020 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant