Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Update CONTRIBUTING.md #166

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Update CONTRIBUTING.md #166

merged 1 commit into from
Jul 18, 2020

Conversation

daadaadaah
Copy link
Contributor

@daadaadaah daadaadaah commented Jul 18, 2020

Specify project

Server

Description

Update postgresql command related to environment setting.

The commands for postgresql about GRANT are as follows :

  1. GRANT CONNECT ON DATABASE database_name TO role_specification;
  2. GRANT ALL PRIVILEGES ON DATABASE database_name TO role_specification;

Once I changed the command to the following criteria.

  1. dev environment
  • DATABASE : hackatalk
  • role_specification: postgres
  1. test environment
  • DATABASE : test
  • role_specification: postgres
  • schema : test1

If there is another setting you have in mind, you can change it like that.

Related Issues

None

Tests

None

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect! Thanks.

@hyochan
Copy link
Owner

hyochan commented Jul 18, 2020

Please sign in to cla.

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files          24       24           
  Lines         453      453           
  Branches       33       33           
=======================================
  Hits          307      307           
  Misses        133      133           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999d790...e7f00ca. Read the comment docs.

@hyochan hyochan merged commit 77e407c into hyochan:master Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants