Finish transaction is called too quickly

[solidfox]

Version of react-native-iap

3.2.4

Version of react-native

0.59.9

Platforms you faced the error (IOS or Android or both?)

iOS (Android not yet confirmed)

Expected behavior

1. A purchase goes through at the StoreKit side.
2. The receipt is sent to the react-native-iap subscription.
3. Something goes wrong and sending the receipt to the server fails.
4. User restarts the app.
5. StoreKit re-emits the SKPaymentTransactionStatePurchased event.
6. The receipt is sent to the react-native-iap subscription.
7. Receipt is sent to the app's server for validation and processing.
8. The purchased content is assigned to the user on the server.
9. The server acknowledges the delivery to the client.
10. The client finishes the StoreKit transaction through react-native-iap.

Actual behavior

1. A purchase goes through at the StoreKit side.
2. react-native-iap finishes the StoreKit transaction automatically. 😱
3. The receipt is sent to the react-native-iap subscription.
4. Something goes wrong and sending the receipt to the server fails.
5. User has paid for content that was never delivered.
6. End of the world.

Tested environment (Emulator? Real Device?)

This can be determined directly from this line of code: https://github.com/dooboolab/react-native-iap/blob/df1483db059cddeb6fd1244d583288e5e7f6b20e/ios/RNIapIos.m#L414

Steps to reproduce the behavior

---

IssueHunt Summary

solidfox has been rewarded.

Backers (Total: $30.00)

• hyochan ($30.00)

Submitted pull Requests

• #589 Fix #581 finishTransaction called automatically

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[solidfox]

I'll go ahead and try to solve this on the iOS side but I'd be very happy if someone could tell me if this is handled on the Android side?

[solidfox]

This seems to serve the same purpose as acknowledging a purchase on Android so it should fit well into that existing api.

Edit: that should be consumeAsync for consumables.

[hyochan]

Could you kindly support us with PR or any docs that we can go over?

[solidfox]

Absolutely, I'll try to make time to do a PR next week. In the meantime here is the apple documentation that explains that one should deliver the purchased material before calling finishTransaction and that SK will persist and keep providing the transaction to the observer until finish has been called.

The Provide Content and Finish the Transaction section in this document

[solidfox]

I believe the correct way to handle this would be to simply expose the finishTransaction method in the react-native-iap library. To avoid breaking changes I'd suggest adding a parameter dangerouslyFinishTransactionAutomatically to the requestPurchase function and default that too true. Then do console warnings for anyone not explicitly setting that parameter that they should update their flow. The parameter can then be removed or defaulted to false in v4.0.0.

[hyochan]

@solidfox Sounds great!! Looking forward for your PR!

[hyochan]

@solidfox How are you going with this? Would you prefer better performance if we can reward on the update? I will charge extra $30 for this for your help.

[issuehunt-oss]

@hyochan has funded $30.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[solidfox]

@hyochan I started working on it today but got a bit caught up in getting the example running only to realize that the example isn't able to make purchases anyway so I guess I'll test it in my own use case.

I also noticed the remains of this commit that seems to be trying to achieve what I'm doing: edfbd12

Only seems to be cruft left though so I guess it was removed at some point?

[solidfox]

Would it be possible to get access to the flow in the documentation to add in registering the purchase with the apps server and acknowledging / finishing the transaction?

[hyochan]

@solidfox Hey great request! If you tell me your email address, I'll invite you to that diagram in draw.io

[solidfox]

@hyochan Thanks! You can send the invite to daniel.schlaug at gmail.

[hyochan]

@solidfox I've just shared the diagram to your email. Thanks!

[issuehunt-oss]

@hyochan has rewarded $21.00 to @solidfox. See it on IssueHunt

• 💰 Total deposit: $30.00
• 🎉 Repository reward(20%): $6.00
• 🔧 Service fee(10%): $3.00