-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item#references: support keywords with UTF8 symbols #485
Item#references: support keywords with UTF8 symbols #485
Conversation
@jacebrowning I need your advice on this. I noticed this while working on the multiple references feature one year ago: all tests work with the shared Would it make sense to create another folder for the test fixtures where they would be maintained "one folder per test case" such as If I am good to go, I would do this change right away. |
@Korijn,
I might take a closer look later or feel free to check my branch and use it as a base. |
@stanislaw Yeah, that makes sense to me! |
I see that it's failing on a .PNG file, I don't think that needs to be supported, right? It looks like pyficache would return None for unreadable files instead of raising SyntaxError. I think we can just try/except that? I can have a look and help fix this later. Thanks for picking this up btw! |
doorstop/core/tests/test_fixtures/001-item-references-utf8-keyword/REQ-UTF8.yml
Outdated
Show resolved
Hide resolved
By the way, I checked, pyficache indeed returns |
The last step is to remove |
@jacebrowning Thanks! The change is in. This should simplify work with these test cases in the future! |
Awesome work! Thanks :) |
doorstop/core/tests/test_fixtures/001-item-references-utf8-keyword/REQ-UTF8.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
I've uploaded this change here: https://pypi.org/project/doorstop/2.2b1/ |
This is a starting point for fixing #484.
For now, a test case is added with the
français
keyword as reported in the issue. In the test case, the reference is found without a problem on macOS. Let's see if the test fails on the other systems supported by CI.Later update: the test indeed was failing on Windows. The solution suggested by @Korijn was to replace the usage of
pyficache
withlinecache
.