-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop floats for inline-block #3
Comments
hmm - good question, I haven't got a real reason why I use floats, it's just what has always worked best for me. I'll test this out and see how it handles it. Thanks |
I'm curious why you reverted back to floats? |
hey man - the grid broke when resizing in Firefox |
Hmm, not for me. I tested this back to ie8 no problem. Perhaps something in one of your later commits modified something that wasn't in an early copy of lemonade I started working off of (and modifying to my delight). Do you have a test page? I'd be really interested to see how it fails. I can also get one up myself in the next day or two showing this working chrome/firefox/ie8-10. |
Oh derr! What's killing it is the last-of-type selector, which was the first thing I axed. Obviously without the frames that's not going to work. Here it is working cross-browser without last-of-type: My two cents: drop the last-of-type. It breaks browser compatibility, bloats the markup, not sure it actually offers any real benefit, and if it does it's a somewhat opinionated default. Plus you get rid of that, add a max-width for < ie9, and you claim browser compatibility back through ie8 which is pretty awesome. |
hey man - just gonna stick with the floats, they work great and i've not experienced any problems with them yet. thanks anyway man |
Thought I'd open this up for discussion.
Idea: get rid of the frames, convert floats to inline-block. That way you don't need the extra divs for rows, and then you just change the "bit-" style to:
[class*='bit-'] {
display:inline-block;
padding: 5px;
margin-right: -.25em;
vertical-align: top;
}
Seems even simpler and works like a champ for me. Is there any reason not to do this?
*lifting this idea from toast, http://daneden.me/toast/
The text was updated successfully, but these errors were encountered: