Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add a config to read files from optifine/* directory #5

Closed
MeeniMc opened this issue Jun 27, 2021 · 3 comments
Closed

[FEATURE] add a config to read files from optifine/* directory #5

MeeniMc opened this issue Jun 27, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MeeniMc
Copy link

MeeniMc commented Jun 27, 2021

Version

0.3.3

Issue

The CEM addon doesn't read the entity models from the optifine directory, but from another directory instead. The models themselves are (as far as I tested) compatible, so the only impediment to using existing resource packs is that one has to convert them. The task is not hard, but it is an annoying extra step.

Proposed enhancement

The CEM mod would also load models from the optifine/* directory. This could be an optional behavior that could be set on (or off? depending on how much incompatibilities are expected to be an issue, it maybe would make sense for this to be default behavior) with a config file/modmenu config.

@MeeniMc MeeniMc added the bug Something isn't working label Jun 27, 2021
@dorianpb dorianpb added the enhancement New feature or request label Jun 27, 2021
@dorianpb dorianpb self-assigned this Jun 27, 2021
@dorianpb
Copy link
Owner

This would actually probably be easier to implement than I thought it would, I'll look into it. I'm not experienced at making modmenu config screens though so it will be a little while

@dorianpb dorianpb added good first issue Good for newcomers and removed bug Something isn't working labels Jun 27, 2021
@dorianpb
Copy link
Owner

Also I love the formatting you used for this issue, very clear and concise!

@dorianpb
Copy link
Owner

dorianpb commented Jul 2, 2021

Commit 9140507 implements this.

@dorianpb dorianpb closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants