Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck Boxes in Deck Lists page should display a card art #26

Closed
3 tasks done
doriongilmore opened this issue Aug 4, 2020 · 0 comments
Closed
3 tasks done

Deck Boxes in Deck Lists page should display a card art #26

doriongilmore opened this issue Aug 4, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@doriongilmore
Copy link
Owner

doriongilmore commented Aug 4, 2020

Describe the solution you'd like

With bootstrap a "deck row" now looks like this :
image

It's quite easy to add an image at the top of these boxes, would be nice to display card art of user choice.
Since we use scryfall API, a lot of work is already done : https://scryfall.com/docs/api/images
"art_crop" property is exactly what we need, we will also need the "artist" property as stated in guidelines : "List the artist name and copyright elsewhere in the same interface presenting the art crop"

  • keep art_crop and artist properties in memory
  • In settings tab of Deck Edition page - choose a card to display
  • Update DeckList to display an image (and its artist) for each deck where configured

Additional context

Render on Untap.in : In our case the artist could be displayed in the badge instead of the deck price

Untap image

@doriongilmore doriongilmore added the enhancement New feature or request label Aug 4, 2020
@doriongilmore doriongilmore mentioned this issue Aug 4, 2020
39 tasks
@doriongilmore doriongilmore self-assigned this Sep 13, 2020
doriongilmore added a commit that referenced this issue Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant