refactor: make all services context managers #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging dcd53d1 into 05c93cd - view on LGTM.com new alerts:
|
doronz88
force-pushed
the
refactor/service_context_managers
branch
from
dcd53d1
to
8965059
Compare
|
This pull request introduces 1 alert when merging 8965059 into 05c93cd - view on LGTM.com new alerts:
|
|
I think it will be better to open the connection on entering instead in the constructor. |
|
@vToMy you are definetely correct but such a change will both:
|
doronz88
force-pushed
the
refactor/service_context_managers
branch
from
8965059
to
9837f45
Compare
|
This pull request introduces 1 alert when merging 9837f45 into 05c93cd - view on LGTM.com new alerts:
|
doronz88
force-pushed
the
refactor/service_context_managers
branch
from
9837f45
to
ee89638
Compare
|
For backward compatability it's possible to have some kind of ctor flag (similar to autopair in lockdown) |
doronz88
force-pushed
the
refactor/service_context_managers
branch
4 times, most recently
from
24dcf54
to
9b84c21
Compare
|
This pull request introduces 1 alert when merging 9b84c21 into 05c93cd - view on LGTM.com new alerts:
|
doronz88
force-pushed
the
refactor/service_context_managers
branch
from
9b84c21
to
022badc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.