Fix #25375: Template Builder Reduce Autosave to 5 Seconds (#25511)

* reduce 10 seconds to 5 * add constant * add backticks to show dynamic debounce time
dotCMS · Jul 20, 2023 · 062be66 · 062be66
1 parent 683db06
commit 062be66
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...i/src/app/portlets/dot-edit-page/layout/dot-edit-layout/dot-edit-layout.component.spec.ts b/...i/src/app/portlets/dot-edit-page/layout/dot-edit-layout/dot-edit-layout.component.spec.ts
@@ -29,7 +29,7 @@ import {
     processedContainers
 } from '@dotcms/utils-testing';
 
-import { DotEditLayoutComponent } from './dot-edit-layout.component';
+import { DEBOUNCE_TIME, DotEditLayoutComponent } from './dot-edit-layout.component';
 
 @Component({
     // eslint-disable-next-line @angular-eslint/component-selector
@@ -239,7 +239,7 @@ describe('DotEditLayoutComponent', () => {
                 expect(component.pageState).toEqual(new DotPageRender(mockDotRenderedPage()));
             });
 
-            it('should save the layout after 10000', fakeAsync(() => {
+            it(`should save the layout after ${DEBOUNCE_TIME}`, fakeAsync(() => {
                 const res: DotPageRender = new DotPageRender(mockDotRenderedPage());
                 spyOn(dotPageLayoutService, 'save').and.returnValue(of(res));
 
@@ -249,7 +249,7 @@ describe('DotEditLayoutComponent', () => {
                     title: null
                 });
 
-                tick(10000);
+                tick(DEBOUNCE_TIME);
                 expect(dotGlobalMessageService.loading).toHaveBeenCalledWith('Saving');
                 expect(dotGlobalMessageService.success).toHaveBeenCalledWith('Saved');
                 expect(dotGlobalMessageService.error).not.toHaveBeenCalled();
@@ -307,7 +307,7 @@ describe('DotEditLayoutComponent', () => {
                 // Destroy the observable
                 component.destroy$.next(true);
                 component.destroy$.complete();
-                tick(10000);
+                tick(DEBOUNCE_TIME);
 
                 expect(dotPageLayoutService.save).not.toHaveBeenCalled();
             }));

diff --git a/...cms-ui/src/app/portlets/dot-edit-page/layout/dot-edit-layout/dot-edit-layout.component.ts b/...cms-ui/src/app/portlets/dot-edit-page/layout/dot-edit-layout/dot-edit-layout.component.ts
@@ -26,6 +26,8 @@ import {
     FeaturedFlags
 } from '@dotcms/dotcms-models';
 
+export const DEBOUNCE_TIME = 5000;
+
 @Component({
     selector: 'dot-edit-layout',
     templateUrl: './dot-edit-layout.component.html',
@@ -145,7 +147,7 @@ export class DotEditLayoutComponent implements OnInit, OnDestroy {
             .pipe(
                 // debounceTime should be before takeUntil to avoid calling the observable after unsubscribe.
                 // More information: https://stackoverflow.com/questions/58974320/how-is-it-possible-to-stop-a-debounced-rxjs-observable
-                debounceTime(10000),
+                debounceTime(DEBOUNCE_TIME),
                 takeUntil(this.destroy$),
                 switchMap((layout: DotTemplateDesigner) => {
                     this.dotGlobalMessageService.loading(