Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Builder: Fix Autosave Feature #25375

Closed
Tracked by #24535
fmontes opened this issue Jun 28, 2023 · 9 comments · Fixed by #25389, #25474 or #25511
Closed
Tracked by #24535

Template Builder: Fix Autosave Feature #25375

fmontes opened this issue Jun 28, 2023 · 9 comments · Fixed by #25389, #25474 or #25511
Assignees
@zJaaal @rjvelazco
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.08.16 Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Jun 28, 2023 •
edited

Problem Statement

Currently, in the template builder, the autosave feature is enabled in the template portlet, but should only be enabled in the layout builder.

Steps to Reproduce

  1. Log in to the dotCMS backend
  2. Go to edit page
  3. Edit a layout
  4. Move something and wait and see how autosave is triggered after 10 seconds.

Acceptance Criteria

  1. Autosave should be removed from the template portlet
  2. Autosave in the layout editor should not trigger when no changes happen
  3. In layout builder, when user tries to go out the route the autosave should trigger right away

External Links

N/A

Assumptions & Initiation Needs

N/A

Quality Assurance Notes & Workarounds

  1. Test the functionality after the removal of the autosave feature in the template portlet to ensure it does not interfere with the autosave feature in the layout builder.
  2. As a workaround, users can manually save their changes in the template portlet.
@fmontes fmontes mentioned this issue Jun 28, 2023
Closed
@fmontes fmontes changed the title Template Builder: Remove Autosave Feature in Template Portlet Template Builder: Fix Autosave Feature Jun 28, 2023
@zJaaal zJaaal self-assigned this Jun 29, 2023
@zJaaal zJaaal linked a pull request Jun 29, 2023 that will close this issue
Fix #25375: Template Builder Fix Autosave Feature #25389
Merged
@zJaaal zJaaal mentioned this issue Jun 30, 2023
Closed
fmontes pushed a commit that referenced this issue Jul 7, 2023
@zJaaal
Fix #25375: Template Builder Fix Autosave Feature (#25389)
09ca574 
* remove auto publish and save from template portlet

* fix save triggering on init

* fix autosave on leave for new template builder

* add test case

* fix broken tests

* enhance emit of changes

* solve feedback

* add destroy subject

* add test for emit changes

* fix console error

* solve feedback
@fmontes
Copy link
Member Author

fmontes commented Jul 11, 2023

You can't leave from the template detail page by navigating, I think is related with the event we have to autosave.

@zJaaal
Copy link
Contributor

zJaaal commented Jul 11, 2023

Fixing it!

@zJaaal zJaaal linked a pull request Jul 11, 2023 that will close this issue
Fix #25375: Remove Guard for Autosave in Templates Portlet #25474
Merged
@zJaaal zJaaal removed the Needs Work label Jul 11, 2023
fmontes pushed a commit that referenced this issue Jul 11, 2023
@zJaaal
Fix #25375 Template Builder: Fix Autosave Feature
cf758c7
@fmontes
Copy link
Member Author

fmontes commented Jul 13, 2023

Let's make the wait time to 5 seconds.

@zJaaal zJaaal linked a pull request Jul 13, 2023 that will close this issue
Fix #25375: Template Builder Reduce Autosave to 5 Seconds #25511
Merged
fmontes pushed a commit that referenced this issue Jul 14, 2023
@zJaaal
Fix #25375: Template Builder Reduce Autosave to 5 Seconds (#25511)
62f34b0 
* reduce 10 seconds to 5

* add constant

* add backticks to show dynamic debounce time
@danielmdob danielmdob self-assigned this Jul 18, 2023
@danielmdob
Copy link
Contributor

Internal QA layout editor (Passed):
https://www.loom.com/share/6f88416a577943ffab306100c77f5871

@danielmdob
Copy link
Contributor

Internal QA Template Builder (Passed):
https://www.loom.com/share/f51be185bfd64f51943fc900ca183cf0

@danielmdob danielmdob removed their assignment Jul 18, 2023
manuelrojas pushed a commit that referenced this issue Jul 20, 2023
@zJaaal @manuelrojas
Fix #25375: Template Builder Reduce Autosave to 5 Seconds (#25511)
062be66 
* reduce 10 seconds to 5

* add constant

* add backticks to show dynamic debounce time
@bryanboza
Copy link
Member

After th3e discution we need some work here, we need to unify the same behavior (auto save) in both sides

@wezell
Copy link
Contributor

wezell commented Jul 20, 2023

So the autosave is not a blocker for flipping the feature flag - and should not make this "QA Rejected". I think you can close/pass this issue in favor of the new one.

@zJaaal
Copy link
Contributor

zJaaal commented Jul 24, 2023

Here is the issue for the new behavior of the Autosave #25573

@zJaaal zJaaal removed the Needs Work label Jul 24, 2023
@rjvelazco rjvelazco self-assigned this Jul 24, 2023
@josemejias11
Copy link

Approved QA - Tested on master_8d344c7_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

@rjvelazco rjvelazco

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.08.16 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
7 participants
@fmontes @wezell @bryanboza @danielmdob @zJaaal @rjvelazco @josemejias11