fix(experiment-reports): show the input name of the goal in the summa…

…ry (#26482)
dotCMS · Nov 6, 2023 · 2846fa5 · 2846fa5
1 parent 2a037cb
commit 2846fa5
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 20 deletions.
diff --git a/...let/src/lib/dot-experiments-configuration/dot-experiments-configuration.component.spec.ts b/...let/src/lib/dot-experiments-configuration/dot-experiments-configuration.component.spec.ts
@@ -37,7 +37,7 @@ import {
     DotExperimentsConfigurationStore
 } from './store/dot-experiments-configuration-store';
 
-import { DotExperimentsExperimentSummaryComponent } from '../shared/ui/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
+import { DotExperimentsExperimentSummaryComponent } from '../dot-experiments-reports/components/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
 import { DotExperimentsUiHeaderComponent } from '../shared/ui/dot-experiments-header/dot-experiments-ui-header.component';
 import { DotExperimentsInlineEditTextComponent } from '../shared/ui/dot-experiments-inline-edit-text/dot-experiments-inline-edit-text.component';
 

diff --git a/.../portlet/src/lib/dot-experiments-configuration/dot-experiments-configuration.component.ts b/.../portlet/src/lib/dot-experiments-configuration/dot-experiments-configuration.component.ts
@@ -31,7 +31,6 @@ import {
     DotExperimentsConfigurationStore
 } from './store/dot-experiments-configuration-store';
 
-import { DotExperimentsExperimentSummaryComponent } from '../shared/ui/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
 import { DotExperimentsUiHeaderComponent } from '../shared/ui/dot-experiments-header/dot-experiments-ui-header.component';
 import { DotExperimentsInlineEditTextComponent } from '../shared/ui/dot-experiments-inline-edit-text/dot-experiments-inline-edit-text.component';
 
@@ -41,7 +40,6 @@ import { DotExperimentsInlineEditTextComponent } from '../shared/ui/dot-experime
         AsyncPipe,
         NgIf,
         DotExperimentsUiHeaderComponent,
-        DotExperimentsExperimentSummaryComponent,
         DotExperimentsConfigurationVariantsComponent,
         DotExperimentsConfigurationGoalsComponent,
         DotExperimentsConfigurationTrafficComponent,

diff --git a/...riments-experiment-summary.component.html → ...riments-experiment-summary.component.html b/...riments-experiment-summary.component.html → ...riments-experiment-summary.component.html
@@ -15,7 +15,7 @@
         <i class="pi pi-flag"></i>
         <div class="flex-grow-1">
             <span class="font-bold">{{ 'experiments.summary.winner.testing' | dm }} </span>
-            <span data-TestId="goal-label">{{ goalTypeMap[goals.primary.type].label | dm }}</span>
+            <span data-TestId="goal-label">{{ goals.primary.name }}</span>
         </div>
     </div>
     <div class="flex align-items-center justify-content-center gap-3" *ngIf="scheduling">
@@ -42,9 +42,9 @@
             class="p-button-outlined"
             [label]="'Refresh' | dm"
             (click)="updateResults.emit()"
-            pButton
+            data-testId="reload-button"
             icon="pi pi-refresh"
-            data-testId="reload-button"></button>
+            pButton></button>
     </div>
 </div>
 

diff --git a/...riments-experiment-summary.component.scss → ...riments-experiment-summary.component.scss b/...riments-experiment-summary.component.scss → ...riments-experiment-summary.component.scss
diff --git a/...ents-experiment-summary.component.spec.ts → ...ents-experiment-summary.component.spec.ts b/...ents-experiment-summary.component.spec.ts → ...ents-experiment-summary.component.spec.ts
@@ -1,7 +1,7 @@
 import { byTestId, createComponentFactory, Spectator } from '@ngneat/spectator/jest';
 
 import { DotMessageService } from '@dotcms/data-access';
-import { GOAL_TYPES, Goals, RangeOfDateAndTime, SummaryLegend } from '@dotcms/dotcms-models';
+import { Goals, RangeOfDateAndTime, SummaryLegend } from '@dotcms/dotcms-models';
 import { GoalsMock, MockDotMessageService, suggestedWinnerMock } from '@dotcms/utils-testing';
 
 import { DotExperimentsExperimentSummaryComponent } from './dot-experiments-experiment-summary.component';
@@ -30,14 +30,13 @@ describe('DotExperimentsExperimentSummaryComponent', () => {
     });
 
     it('should rendered the goal Input', () => {
+        const GOAL_NAME = GoalsMock.primary.name;
         const goals: Goals = GoalsMock;
         spectator.setInput({
             goals
         });
 
-        expect(spectator.query(byTestId('goal-label'))).toHaveText(
-            spectator.component.goalTypeMap[GOAL_TYPES.REACH_PAGE].label
-        );
+        expect(spectator.query(byTestId('goal-label'))).toHaveText(GOAL_NAME);
     });
 
     it('should rendered the scheduling Input', () => {
@@ -79,6 +78,7 @@ describe('DotExperimentsExperimentSummaryComponent', () => {
             suggestedWinner.legend
         );
     });
+
     it('should rendered session reached number', () => {
         const sessionsReached = 50;
         spectator.setInput({

diff --git a/...periments-experiment-summary.component.ts → ...periments-experiment-summary.component.ts b/...periments-experiment-summary.component.ts → ...periments-experiment-summary.component.ts
@@ -3,12 +3,7 @@ import { ChangeDetectionStrategy, Component, EventEmitter, Input, Output } from
 
 import { ButtonModule } from 'primeng/button';
 
-import {
-    Goals,
-    GOALS_METADATA_MAP,
-    RangeOfDateAndTime,
-    SummaryLegend
-} from '@dotcms/dotcms-models';
+import { Goals, RangeOfDateAndTime, SummaryLegend } from '@dotcms/dotcms-models';
 import { DotMessagePipe } from '@dotcms/ui';
 
 @Component({
@@ -20,8 +15,6 @@ import { DotMessagePipe } from '@dotcms/ui';
     changeDetection: ChangeDetectionStrategy.OnPush
 })
 export class DotExperimentsExperimentSummaryComponent {
-    goalTypeMap = GOALS_METADATA_MAP;
-
     @Input()
     goals: Goals;
 

diff --git a/...riments/portlet/src/lib/dot-experiments-reports/dot-experiments-reports.component.spec.ts b/...riments/portlet/src/lib/dot-experiments-reports/dot-experiments-reports.component.spec.ts
@@ -26,6 +26,7 @@ import {
 } from '@dotcms/utils-testing';
 import { DotHttpErrorManagerService } from '@services/dot-http-error-manager/dot-http-error-manager.service';
 
+import { DotExperimentsExperimentSummaryComponent } from './components/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
 import { DotExperimentsReportDailyDetailsComponent } from './components/dot-experiments-report-daily-details/dot-experiments-report-daily-details.component';
 import { DotExperimentsReportsChartComponent } from './components/dot-experiments-reports-chart/dot-experiments-reports-chart.component';
 import { DotExperimentsReportsSkeletonComponent } from './components/dot-experiments-reports-skeleton/dot-experiments-reports-skeleton.component';
@@ -35,7 +36,6 @@ import {
     VmReportExperiment
 } from './store/dot-experiments-reports-store';
 
-import { DotExperimentsExperimentSummaryComponent } from '../shared/ui/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
 import { DotExperimentsUiHeaderComponent } from '../shared/ui/dot-experiments-header/dot-experiments-ui-header.component';
 
 const ActivatedRouteMock = {

diff --git a/...-experiments/portlet/src/lib/dot-experiments-reports/dot-experiments-reports.component.ts b/...-experiments/portlet/src/lib/dot-experiments-reports/dot-experiments-reports.component.ts
@@ -23,6 +23,7 @@ import { DotMessagePipe } from '@dotcms/ui';
 import { DotPipesModule } from '@pipes/dot-pipes.module';
 import { DotDynamicDirective } from '@portlets/shared/directives/dot-dynamic.directive';
 
+import { DotExperimentsExperimentSummaryComponent } from './components/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
 import { DotExperimentsReportDailyDetailsComponent } from './components/dot-experiments-report-daily-details/dot-experiments-report-daily-details.component';
 import { DotExperimentsReportsChartComponent } from './components/dot-experiments-reports-chart/dot-experiments-reports-chart.component';
 import { DotExperimentsReportsSkeletonComponent } from './components/dot-experiments-reports-skeleton/dot-experiments-reports-skeleton.component';
@@ -32,7 +33,6 @@ import {
 } from './store/dot-experiments-reports-store';
 
 import { DotExperimentsDetailsTableComponent } from '../shared/ui/dot-experiments-details-table/dot-experiments-details-table.component';
-import { DotExperimentsExperimentSummaryComponent } from '../shared/ui/dot-experiments-experiment-summary/dot-experiments-experiment-summary.component';
 import { DotExperimentsUiHeaderComponent } from '../shared/ui/dot-experiments-header/dot-experiments-ui-header.component';
 
 @Component({