fix(announcements): Fix the error showing in the onchange (#27777)

* #27773 Fix the error showing in the onchange * Adding test * Adding test
dotCMS · Mar 1, 2024 · 8328aa1 · 8328aa1
1 parent 84d170e
commit 8328aa1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...-toolbar/components/dot-toolbar-announcements/dot-toolbar-announcements.component.spec.ts b/...-toolbar/components/dot-toolbar-announcements/dot-toolbar-announcements.component.spec.ts
@@ -111,4 +111,18 @@ describe('DotToolbarAnnouncementsComponent', () => {
         const announcementLink = spectator.query(byTestId('announcements__about-link'));
         expect(announcementLink.getAttribute('target')).toBe('_blank');
     });
+
+    it('should call markAnnouncementsAsRead on ng on init', () => {
+        const refreshUtmParametersSpy = spyOn(
+            spectator.component.announcementsStore,
+            'refreshUtmParameters'
+        );
+        spectator.component.ngOnInit();
+        expect(refreshUtmParametersSpy).toHaveBeenCalled();
+
+        // Checking that is not called again in the ngOnChanges
+        refreshUtmParametersSpy.calls.reset();
+        spectator.component.ngOnChanges({ showUnreadAnnouncement: { currentValue: false } });
+        expect(refreshUtmParametersSpy).not.toHaveBeenCalled();
+    });
 });
diff --git a/...s/dot-toolbar/components/dot-toolbar-announcements/dot-toolbar-announcements.component.ts b/...s/dot-toolbar/components/dot-toolbar-announcements/dot-toolbar-announcements.component.ts
@@ -61,12 +61,12 @@ export class DotToolbarAnnouncementsComponent implements OnInit, OnChanges {
 
     ngOnInit(): void {
         this.announcementsStore.load();
+        this.announcementsStore.refreshUtmParameters();
         this.aboutLinks = this.getAboutLinks();
     }
 
     ngOnChanges(changes): void {
         if (!changes.showUnreadAnnouncement.currentValue) {
-            this.announcementsStore.refreshUtmParameters();
             this.announcementsStore.markAnnouncementsAsRead();
         }
     }