Fix #24361 block editor code block should not show suggestions or pla…

…ceholder (#24403) * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * build file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
dotCMS · Mar 20, 2023 · a1727c2 · a1727c2
1 parent fb6e085
commit a1727c2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/core-web/libs/block-editor/src/lib/components/dot-block-editor/dot-block-editor.component.ts b/core-web/libs/block-editor/src/lib/components/dot-block-editor/dot-block-editor.component.ts
@@ -46,7 +46,8 @@ import {
     BubbleAssetFormExtension,
     ImageUpload,
     FreezeScroll,
-    FREEZE_SCROLL_KEY
+    FREEZE_SCROLL_KEY,
+    NodeTypes
 } from '../../extensions';
 import { ContentletBlock, ImageNode, VideoNode } from '../../nodes';
 import {
@@ -397,10 +398,14 @@ export class DotBlockEditorComponent implements OnInit, OnDestroy {
      * @memberof DotBlockEditorComponent
      */
     private placeholder({ node }) {
-        if (node.type.name === 'heading') {
+        if (node.type.name === NodeTypes.HEADING) {
             return `${toTitleCase(node.type.name)} ${node.attrs.level}`;
         }
 
+        if (node.type.name === NodeTypes.CODE_BLOCK) {
+            return;
+        }
+
         return 'Type "/" for commmands';
     }
 

diff --git a/core-web/libs/block-editor/src/lib/extensions/action-button/actions-menu.extension.ts b/core-web/libs/block-editor/src/lib/extensions/action-button/actions-menu.extension.ts
@@ -238,7 +238,11 @@ export const ActionsMenu = (
             findParentNode(editor.view.state.selection.$from, [NodeTypes.TABLE_CELL])?.type.name ===
             NodeTypes.TABLE_CELL;
 
-        shouldShow = !isTableCell;
+        const isCodeBlock =
+            findParentNode(editor.view.state.selection.$from, [NodeTypes.CODE_BLOCK])?.type.name ===
+            NodeTypes.CODE_BLOCK;
+
+        shouldShow = !isTableCell && !isCodeBlock;
     }
 
     function setUpSuggestionComponent(editor: Editor, range: Range) {

diff --git a/dotCMS/src/main/webapp/html/dotcms-block-editor.js b/dotCMS/src/main/webapp/html/dotcms-block-editor.js