Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block editor Code block should not show suggestions or placeholder #24361

Closed
2 tasks done
Tracked by #21988
fmontes opened this issue Mar 13, 2023 · 2 comments · Fixed by #24403
Closed
2 tasks done
Tracked by #21988

Block editor Code block should not show suggestions or placeholder #24361

fmontes opened this issue Mar 13, 2023 · 2 comments · Fixed by #24403
Assignees
@manuelrojas @rjvelazco
Labels
OKR : Code Maintenance Owned by Erick Priority : 3 Average QA : Approved QA : Passed Internal Release : 23.05 Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Mar 13, 2023 •
edited by manuelrojas

Parent Issue

#21988

Problem Statement

When you create a code block is showing like a regular paragraph or heading block and it should not meaning:

  1. It allows the user to show the suggestions menu with /
  2. It shows the placeholder "Type / for ..."

Steps to Reproduce

  1. Open a block editor field
  2. Add a code block
  3. See the error

Acceptance Criteria
Beta Give feedback

dotCMS Version

23.03

Proposed Objective

Code Maintenance

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@fmontes fmontes mentioned this issue Mar 13, 2023
Closed
@fmontes fmontes changed the title Block editor code should not show suggestions or placeholder Block editor Code block should not show suggestions or placeholder Mar 15, 2023
@manuelrojas manuelrojas self-assigned this Mar 16, 2023
manuelrojas added a commit that referenced this issue Mar 16, 2023
@manuelrojas
#24361 Blocking suggestions and placeholder
ad3dec4
manuelrojas added a commit that referenced this issue Mar 16, 2023
@manuelrojas
#24361 Blocking suggestions and placeholder
87d3eff
@manuelrojas manuelrojas linked a pull request Mar 16, 2023 that will close this issue
Issue 24361 block editor code block should not show suggestions or placeholder #24403
Merged
3 tasks
manuelrojas added a commit that referenced this issue Mar 17, 2023
@manuelrojas
#24361 Blocking suggestions and placeholder
58a80c3
manuelrojas added a commit that referenced this issue Mar 17, 2023
@manuelrojas
#24361 Blocking suggestions and placeholder
b182dac
fmontes added a commit that referenced this issue Mar 20, 2023
@manuelrojas @fmontes
Fix #24361 block editor code block should not show suggestions or pla…
a1727c2 
…ceholder (#24403)

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* build file

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
@rjvelazco rjvelazco self-assigned this Mar 30, 2023
@rjvelazco
Copy link
Contributor

Passed Internal QA

Docker Image: [dotcms/dotcms:master_4ea0b063]

internalqa-issue-24361-block-editor-code-block-should-not-show-suggestions-or-placeholder.mov

@josemejias11
Copy link

Approved QA - Tested on 23.05_86e392fc_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuelrojas manuelrojas

@rjvelazco rjvelazco

Labels
OKR : Code Maintenance Owned by Erick Priority : 3 Average QA : Approved QA : Passed Internal Release : 23.05 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 24361 block editor code block should not show suggestions or placeholder dotCMS/core
4 participants
@fmontes @manuelrojas @rjvelazco @josemejias11