Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Edit mode broke in medium size screens #18203

Closed
fmontes opened this issue Mar 27, 2020 · 10 comments
Closed

UI: Edit mode broke in medium size screens #18203

fmontes opened this issue Mar 27, 2020 · 10 comments
Assignees
@ivorpad
Labels
dotCMS : Admin Tools Merged QA : Approved QA : Passed Internal Release : 5.3.9 Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Mar 27, 2020

Describe the bug

The toolbar of edit mode is broken in medium size screen

Screen Shot 2020-03-27 at 2 46 26 PM

  1. Match the design
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
@fmontes fmontes added this to the Bug Sprint milestone Mar 27, 2020
@alfredo-dotcms
Copy link
Contributor

alfredo-dotcms commented May 26, 2020 •
edited
Loading

  • Previewing label must be placed above the device view (Remove "Previewing:")
  • Lock icon must be positioned next to the CANCEL button
  • Language and Device dropdown should hide labels when viewport is narrow

image

Pd: this still needs to be discussed by the design team

@alfredo-dotcms alfredo-dotcms removed their assignment Jun 18, 2020
@nollymar nollymar modified the milestones: Bug Sprint, Scout Current, 072820_SCOUT Jul 17, 2020
@alfredo-dotcms
Copy link
Contributor

core-web working branch: issue-18203-UI-Edit-Mode-Broken-On-Tablet

@alfredo-dotcms
Copy link
Contributor

alfredo-dotcms commented Jul 24, 2020 •
edited
Loading

changes so far:

image

image

--- o ---

image

image

@fmontes
Copy link
Member Author

fmontes commented Jul 27, 2020

Untitled-3

  1. Move "Save" message to a toast
  2. Lang, device and persona all collapsed and tooltip to show the selected option
  3. Lock switch message "locker by..." into a tooltip.
  4. Remove the message of "Phone - 414 x 731

alfredo-dotcms added a commit to dotCMS/core-web that referenced this issue Jul 30, 2020
@alfredo-dotcms
add tests dotCMS/core#18203
10a3e83
@nollymar
Copy link
Contributor

nollymar commented Aug 4, 2020

PR: dotCMS/core-web#1391

nollymar pushed a commit to dotCMS/core-web that referenced this issue Aug 4, 2020
@alfredo-dotcms
dotCMS/core#18203 Issue 18203 ui edit mode broken on tablet (#1391)
22b6a0b 
* Progress

* rollback

* new temp style alignment

* new refactor

* format files

* add tests dotCMS/core#18203

* fix broken tests

* add missing test
@nollymar nollymar modified the milestones: Scout Current, Bug Sprint Aug 4, 2020
@dsilvam
Copy link
Contributor

dsilvam commented Aug 10, 2020

Passed Internal QA:
These four items working as expected

  1. Move "Save" message to a toast
  2. Lang, device and persona all collapsed and tooltip to show the selected option
  3. Lock switch message "locker by..." into a tooltip.
  4. Remove the message of "Phone - 414 x 731

@bryanboza
Copy link
Member

We need some work here:

If the display is smaller than the device size, we need add some scroll here in order to allow see the complete screen
image

alfredo-dotcms added a commit to dotCMS/core-web that referenced this issue Aug 19, 2020
@alfredo-dotcms
dotCMS/core#18203 fix
fa489f6
@alfredo-dotcms
Copy link
Contributor

PR: dotCMS/core-web#1414

@fmontes fmontes assigned fmontes and unassigned fmontes Aug 26, 2020
@ivorpad ivorpad assigned ivorpad and unassigned alfredo-dotcms Aug 27, 2020
@ivorpad
Copy link
Contributor

ivorpad commented Aug 29, 2020

PR: dotCMS/core-web#1424

fmontes pushed a commit to dotCMS/core-web that referenced this issue Sep 8, 2020
@ivorpad
dotCMS/core#18203 UI: Edit mode broke in medium size screens
ae3e82e 
* Fixed scrolling issue in Edit Mode

* Fixed issue with layout

* Visibility and position properties were put back in the iframe

* Bugfix:
Fixes issue with tablet layouts in portrait and landscape

* Fixed padding

* Fixed DotEditContentComponent tests

- Fixed test for dot-edit__iframe
- Added test for dot-edit__device-wrapper

* Code review fixes:

- Changed setTimeout for whenStable
- Added padding only when `deviced`

* Removed `done` as it wasn't needed
@bryanboza
Copy link
Member

Fixed, tested on master // Postgres // FF

@fmontes fmontes closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivorpad ivorpad

Labels
dotCMS : Admin Tools Merged QA : Approved QA : Passed Internal Release : 5.3.9 Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ivorpad @fmontes @wezell @dsilvam @bryanboza @erickgonzalez @nollymar @alfredo-dotcms