Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stealing lock by clicking Edit tab on locked page does not unlock the page #18204

Closed
wezell opened this issue Mar 27, 2020 · 7 comments
Closed

Stealing lock by clicking Edit tab on locked page does not unlock the page #18204

wezell opened this issue Mar 27, 2020 · 7 comments
Labels
dotCMS : Admin Tools Merged QA : Approved QA : Passed Internal Release : 5.3.7 Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Mar 27, 2020 •
edited
Loading

If you edit a page that is locked by another user, and hit edit and have permissions, you are given the choice to "steal the lock". If you click "Accept", the page gets reset into preview mode and the lock never gets stolen.

Try this on the costa rica page as admin@dotcms.com

lock-no-workee
@wezell wezell added this to the Bug Sprint milestone Mar 27, 2020
@erickgonzalez erickgonzalez self-assigned this Mar 30, 2020
@erickgonzalez
Copy link
Contributor

Tested this against the latest master and can not reproduce. The lock is stolen and the page view stays at Edit Mode.

@erickgonzalez erickgonzalez removed their assignment Mar 30, 2020
@wezell
Copy link
Contributor Author

wezell commented Mar 30, 2020

When the page is locked, you need to hit the "Edit Tab" and not the "unlock" switch.

@erickgonzalez
Copy link
Contributor

@wezell Yes, I tested the same steps that you did on the video

@erickgonzalez
Copy link
Contributor

Screen-Recording-2020-03-30-at-1

@erickgonzalez erickgonzalez self-assigned this Mar 30, 2020
@wezell wezell closed this as completed Apr 15, 2020
@erickgonzalez erickgonzalez removed their assignment Jun 2, 2020
@fmontes fmontes reopened this Jul 27, 2020
@alfredo-dotcms alfredo-dotcms self-assigned this Jul 31, 2020
alfredo-dotcms added a commit to dotCMS/core-web that referenced this issue Aug 3, 2020
@alfredo-dotcms
dotCMS/core#18204 fix
116fc51
nollymar pushed a commit to dotCMS/core-web that referenced this issue Aug 4, 2020
@alfredo-dotcms
dotCMS/core#18204 Issue 18204 stealing lock by clicking edit tab on l…
70525be 
…ocked page broken (#1394)

* dotCMS/core#18204 fix

* add tests
@nollymar
Copy link
Contributor

nollymar commented Aug 4, 2020

PR: dotCMS/core-web#1394

@dsilvam
Copy link
Contributor

dsilvam commented Aug 7, 2020

Passed Internal QA: Able to steal lock by clicking on Edit tab and able to make changes.

@bryanboza
Copy link
Member

Fixed, unable to reproduce on the release-5.3.7 branch after the last changes

@wezell wezell closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : Admin Tools Merged QA : Approved QA : Passed Internal Release : 5.3.7 Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@fmontes @wezell @dsilvam @bryanboza @erickgonzalez @nollymar @alfredo-dotcms