Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update starter import/export format to be json #19400

Closed
nollymar opened this issue Oct 7, 2020 · 3 comments · Fixed by #21236
Closed

Update starter import/export format to be json #19400

nollymar opened this issue Oct 7, 2020 · 3 comments · Fixed by #21236
Labels
Changelog: Breaking Change Merged QA : Approved QA : Passed Internal Release : 22.08 Team : Scout Type : Enhancement

Comments

@nollymar
Copy link
Contributor

nollymar commented Oct 7, 2020 •
edited
Loading

This is part of a bigger feature where the main goal is to avoid relying on Hibernate.

Acceptance criteria: Import/Export functionality should keep working as always
@nollymar nollymar modified the milestones: Scout Current, 100620_SCOUT Oct 7, 2020
@john-thomas-dotcms
Copy link
Contributor

So from the description I think the plan is to still support the existing CSV format; but just to be clear - I think the import/export using CSV files will still need to be supported, because it's much, much easier for customers to export CSV files and work with them in a spreadsheet program than it would be for them to work with JSON files.

So if we update the format, we'll need to have two separate/parallel import/export format readers/writers (one for CSV and one for JSON). But the underlying code which takes those results and does things like validate them can (and should) be shared for both formats.

@nollymar nollymar modified the milestones: 102720_SCOUT, Scout Current Oct 28, 2020
@nollymar nollymar modified the milestones: 122921_SCOUT, Scout Current Jan 12, 2021
@nollymar nollymar modified the milestones: 011921_SCOUT, Scout Current Jan 26, 2021
@nollymar nollymar removed this from the Scout Current milestone Oct 26, 2021
@wezell wezell changed the title Update import/export format to be json Update starter import/export format to be json Nov 2, 2021
@nollymar nollymar self-assigned this Nov 3, 2021
nollymar pushed a commit that referenced this issue Nov 4, 2021
#19400 First commit on moving export files as json
9e295f3
nollymar pushed a commit that referenced this issue Nov 19, 2021
#19400 New ImportStarter/ExportStarter implementation using json files
c7ac9cd
nollymar pushed a commit that referenced this issue Nov 19, 2021
#19400 Rolling back last commit
755681e
nollymar pushed a commit that referenced this issue Jun 10, 2022
#19400 Using JsonIgnoreProperties(ignoreUnknown = true) where needed
5440915
nollymar pushed a commit that referenced this issue Jun 16, 2022
#19400 Adding support for importing/exporting ImmutableContentlet
99e5df8
nollymar pushed a commit that referenced this issue Jun 16, 2022
#19400 Import/Export starter with JSON files
008278b
nollymar pushed a commit that referenced this issue Jun 17, 2022
#19400 Cleaning up code
ab46228
nollymar pushed a commit that referenced this issue Jun 17, 2022
#19400 New starter based on JSON
38ebc04
nollymar pushed a commit that referenced this issue Jun 17, 2022
#19400 New tests
79340ff
@nollymar nollymar linked a pull request Jun 17, 2022 that will close this issue
#19400 Import/Export starter using json files #21236
Merged
@nollymar
Copy link
Contributor Author

PR: #21236

nollymar pushed a commit that referenced this issue Jun 27, 2022
#19400 Updating starter
b99d5f8
nollymar added a commit that referenced this issue Jun 28, 2022
@nollymar
#19400 Import/Export starter using json files (#21236)
3b5a126 
* #19400 First commit on moving export files as json

* #19400 New ImportStarter/ExportStarter implementation using json files

* #19400 Rolling back last commit

* #19400 Using JsonIgnoreProperties(ignoreUnknown = true) where needed

* #19400 Adding support for importing/exporting ImmutableContentlet

* #19400 Import/Export starter with JSON files

* #19400 Cleaning up code

* #19400 New starter based on JSON

* #19400 New tests

* Applying code review suggestions

* #19400 Updating starter

Co-authored-by: nollymar <nollymarlonga@Nollymars-MacBook-Pro-2.local>
@nollymar nollymar reopened this Jun 28, 2022
@nollymar nollymar removed their assignment Jun 28, 2022
@alfredo-dotcms alfredo-dotcms self-assigned this Jul 11, 2022
@alfredo-dotcms alfredo-dotcms removed their assignment Jul 11, 2022
@bryanboza
Copy link
Member

Fixed, tested on release-22.07 // Docker // FF.

Now we are able to start the server using a JSON format file as starter, but this is a breaking change, now we are unable to start using a previous starter.

@wezell wezell closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelog: Breaking Change Merged QA : Approved QA : Passed Internal Release : 22.08 Team : Scout Type : Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#19400 Import/Export starter using json files dotCMS/core
6 participants
@wezell @bryanboza @nollymar @john-thomas-dotcms @fabrizzio-dotCMS @alfredo-dotcms