Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the contentlets references up to date in the block editor #22857

Closed
Tracked by #21988
fmontes opened this issue Aug 25, 2022 · 6 comments
Closed
Tracked by #21988

Keep the contentlets references up to date in the block editor #22857

fmontes opened this issue Aug 25, 2022 · 6 comments
Assignees
@jdotcms
Labels
QA : Approved Release : 22.12 Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Aug 25, 2022 •
edited

Is your feature request related to a problem? Please describe.
We author add a contentlet to the block editor (dotContent or dotImage) the data get stored in the block editor json, the issue is that is a field on those contentlets changes is not reflected in the block editor value.

Describe the solution you'd like
We need to use the content of the block editor as references and look for the latest version of the contentlets before return the block editor data.

Describe alternatives you've considered
Use a references object that can be mapped, but if we are doing this better be right inline in the block.

Additional context
N/A

Acceptance criteria

  • Contentlets in the block editor should keep up to date
  • Should work in all the API, content, page, graphql and Elastic Search.
@jdotcms jdotcms self-assigned this Aug 26, 2022
jdotcms added a commit that referenced this issue Aug 26, 2022
@jdotcms
#22857 initial draft and ideas
3e02f1c
jdotcms added a commit that referenced this issue Aug 26, 2022
@jdotcms
#22857 initial draft and ideas
e662762
jdotcms added a commit that referenced this issue Aug 26, 2022
@jdotcms
#22857 initial draft and ideas
70a2df6
jdotcms added a commit that referenced this issue Aug 26, 2022
@jdotcms
#22857 initial draft and ideas
699d6ea
jdotcms added a commit that referenced this issue Aug 26, 2022
@jdotcms
#22857 initial draft and ideas
cbf6f2f
jdotcms added a commit that referenced this issue Aug 26, 2022
@jdotcms
#22857 initial draft and ideas
c68edba
jdotcms added a commit that referenced this issue Aug 29, 2022
@jdotcms
#22857 final changes
938b2ed
jdotcms added a commit that referenced this issue Aug 30, 2022
@jdotcms
˜#22857 adding the story block api
3df7c1b
jdotcms added a commit that referenced this issue Aug 30, 2022
@jdotcms
#22857 the refresh happens now even on cached contentlets
f6943a8
jdotcms added a commit that referenced this issue Aug 31, 2022
@jdotcms
#22857 adding some minor changes
b6c60cc
jdotcms added a commit that referenced this issue Aug 31, 2022
@jdotcms
#22857 adding unit test for update references
717a0c3
jdotcms added a commit that referenced this issue Aug 31, 2022
@jdotcms
#22857 unit test for getDependencies
20e3c74
jdotcms added a commit that referenced this issue Aug 31, 2022
@jdotcms
#22857 unit test for getDependencies
ca9d726
@fmontes
Copy link
Member Author

fmontes commented Sep 1, 2022

Branch to test issue-22857-refresh-content-editor

jdotcms added a commit that referenced this issue Sep 1, 2022
@jdotcms
#22857 merge master done
d97d420
jdotcms added a commit that referenced this issue Sep 2, 2022
@jdotcms
#22857 adding feedback
99d45de
jdotcms added a commit that referenced this issue Sep 2, 2022
@jdotcms
#22857 adding more feedback
76ea624
jdotcms added a commit that referenced this issue Sep 2, 2022
@jdotcms
#22857 adding more feedback
2adf9bb
jdotcms added a commit that referenced this issue Sep 2, 2022
@jdotcms
#22857 rolling back some config
24cd314
jdotcms added a commit that referenced this issue Sep 2, 2022
@jdotcms
#22857 rolling back some config
47b3303
jdotcms added a commit that referenced this issue Sep 2, 2022
@jdotcms
#22857 adding some logging
22a08d3
jdotcms added a commit that referenced this issue Sep 9, 2022
@jdotcms
#22857 merge master done
3ffc900
@wezell
Copy link
Contributor

wezell commented Sep 9, 2022

We need to benchmark /api calls in this change against the master branch to make sure we are performant.

jdotcms added a commit that referenced this issue Sep 9, 2022
@jdotcms
#22857 adding a fix for searching by query when need to refresh the b…
d5435b6 
…lock editor dependencies
@fmontes fmontes closed this as completed Oct 10, 2022
@fmontes fmontes reopened this Nov 8, 2022
fmontes added a commit that referenced this issue Nov 9, 2022
@jdotcms @fmontes @jcastro-dotcms
#22857 refreshing block editor contentlet reference (#22867)
c4ad2ff 
* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 final changes

* ˜#22857 adding the story block api

* #22857 the refresh happens now even on cached contentlets

* #22857 adding some minor changes

* #22857 adding unit test for update references

* #22857 unit test for getDependencies

* #22857 unit test for getDependencies

* #22857 adding feedback

* #22857 adding more feedback

* #22857 adding more feedback

* #22857 rolling back some config

* #22857 rolling back some config

* #22857 adding some logging

* Rename var

* #22857 adding a fix for searching by query when need to refresh the block editor dependencies

* #22857 adding some flag to control when refresh or not

Co-authored-by: Freddy Montes <freddymontes@gmail.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>
@fmontes
Copy link
Member Author

fmontes commented Nov 10, 2022

@bryanboza @josemejias07 we need to retest this again in 22.10.1_a8062bcc_SNAPSHOT because for some reason it didn't make it into 22.10

@bryanboza
Copy link
Member

Fixed, tested on docker with tag: 22.10.1_a8062bcc_SNAPSHOT

Tested with all the endpoints mentioned by @fmontes in the previous comment and now we are updating the content reference as expected.

fmontes added a commit that referenced this issue Nov 14, 2022
@fmontes @jdotcms
@jcastro-dotcms @victoralfaro-dotcms
Release 22.10.1 to master (#23345)
04897ac 
* #22857 refreshing block editor contentlet reference (#22867)

* #22857 initial draft and ideas

* #22857 final changes

* ˜#22857 adding the story block api

* #22857 the refresh happens now even on cached contentlets

* #22857 adding some minor changes

* #22857 adding unit test for update references

* #22857 unit test for getDependencies

* #22857 adding feedback

* #22857 adding more feedback

* #22857 rolling back some config

* #22857 adding some logging

* Rename var

* #22857 adding a fix for searching by query when need to refresh the block editor dependencies

* #22857 adding some flag to control when refresh or not

Co-authored-by: Freddy Montes <freddymontes@gmail.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>

* CI: bumps version to 22.12.0-rc.0 [skip ci]

* Fix of versions after running code freeze against the release-22.10 branch

* Fixing submodules branch

* Updating enterprise branch

* Revert "Updating enterprise branch"

This reverts commit fab861d.

* Setting correct dorcmsReleaseVersion property

* Updating core-web versions

* Publish Release

* Update package.json

* Update gradle.properties

* Update .gitmodules

* CI: bumps version to 22.12.0-next.5 [skip ci]

Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com>
jcastro-dotcms added a commit that referenced this issue Nov 14, 2022
@jdotcms @fmontes @jcastro-dotcms
#22857 refreshing block editor contentlet reference (#22867)
1f296c7 
* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 initial draft and ideas

* #22857 final changes

* ˜#22857 adding the story block api

* #22857 the refresh happens now even on cached contentlets

* #22857 adding some minor changes

* #22857 adding unit test for update references

* #22857 unit test for getDependencies

* #22857 unit test for getDependencies

* #22857 adding feedback

* #22857 adding more feedback

* #22857 adding more feedback

* #22857 rolling back some config

* #22857 rolling back some config

* #22857 adding some logging

* Rename var

* #22857 adding a fix for searching by query when need to refresh the block editor dependencies

* #22857 adding some flag to control when refresh or not

Co-authored-by: Freddy Montes <freddymontes@gmail.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>
@fmontes fmontes closed this as completed Nov 14, 2022
@fmontes fmontes reopened this Dec 1, 2022
fmontes pushed a commit that referenced this issue Dec 1, 2022
@jdotcms
#22857 Keep the contentlets references up to date in the block editor
a992fdb 
* #22867 cherry pick done

* fixing unit test, a value missing in a msg format
@bryanboza
Copy link
Member

Fixed, tested on release-22.11 // Docker // FF

@fmontes fmontes closed this as completed Dec 5, 2022
fmontes added a commit that referenced this issue Dec 5, 2022
@fmontes @victoralfaro-dotcms
@wezell @jcastro-dotcms @jdotcms
Release 22.12 to master (#23490)
8b92a38 
* Fixing artifact plgin invocation. Need to use Gralde version 6.9.3 in order for this to work.

* #22864 Categories - $contentlet.categories can be slow

* #22864 adding cache for pullAllCategoryChildren

* #22864 adding cache for pullAllCategoryChildren

* #22864 adding cache for pullAllCategoryChildren

* #22864 adding cache for pullAllCategoryChildren

* #22864 much faster

* Fixing Postman Test: `VanityURL.postman_collection.json`

* Removing infinite loop call.

Co-authored-by: Jose Castro <jose.castro@dotcms.com>

* Trigger builds

* CI: bumps version to 22.11.0-rc.5 [skip ci]

* CI: bumps version to 22.11.0-rc.16 [skip ci]

* #23056 : REVERT - Reverting changes in `docker-compose` files. (#23425)

Reverting changes in `docker-compose` files to avoid overwriting important changes already present in `master` branch. Additionally, adding a fix provided by Todd which would add the appropriate `LANG` environment variable when applying the config defaults.

* #23296 Bug: WYSIWYG NPE if it finds an invalid data-elements

* #23401 Insure zip file integrity

* #22857 Keep the contentlets references up to date in the block editor

* #22867 cherry pick done

* fixing unit test, a value missing in a msg format

* CI: bumps version to 22.11.0-rc.6 [skip ci]

* Increase version

* CI: bumps version to 22.12.0-rc.2 [skip ci]

* CI: bumps version to 22.12.0-rc.2 [skip ci]

* Increase version rc (#23486)

* Increase version rc

* Increase version rc

* CI: bumps version to 22.12.0-rc.4 [skip ci]

* CI: bumps version to 22.13.0-next.3 [skip ci]

* CI: bumps version to 23.1.0-next.2 [skip ci]

* Fixing merge conflicts in docker-compose files.

* Bringing LANG variable back.

* CI: bumps version to 23.1.0-next.3 [skip ci]

Co-authored-by: Victor Alfaro <victor.alfaro@dotcms.com>
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
@wezell wezell mentioned this issue Mar 21, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdotcms jdotcms

Labels
QA : Approved Release : 22.12 Team : Lunik Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fmontes @wezell @bryanboza @erickgonzalez @jdotcms