#22857 refreshing block editor contentlet reference #22867

jdotcms · 2022-08-26T22:53:22Z

Initial draft - refreshing block editor contentlets

github-actions · 2022-08-26T22:57:15Z

Postman Tests Report

    63 files 1 273 suites 2h 56m 1s ⏱️
  553 tests   540 ✔️ 0 💤 13 ❌
2 103 runs 2 076 ✔️ 0 💤 27 ❌

For more details on these failures, see this check.

Results for commit 11571ef.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-26T23:27:24Z

Unit Tests Report

1 343 tests 1 333 ✔️ 3m 0s ⏱️
  132 suites     10 💤
  132 files       0 ❌

Results for commit 11571ef.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-27T00:32:52Z

Integration Tests [postgres] Report

  399 files   399 suites 1h 11m 45s ⏱️
3 822 tests 3 799 ✔️ 23 💤 0 ❌
3 841 runs 3 818 ✔️ 23 💤 0 ❌

Results for commit 11571ef.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-27T00:50:47Z

Integration Tests [mssql] Report

  398 files   398 suites 1h 26m 40s ⏱️
3 817 tests 3 786 ✔️ 23 💤 8 ❌
3 836 runs 3 805 ✔️ 23 💤 8 ❌

For more details on these failures, see this check.

Results for commit 11571ef.

♻️ This comment has been updated with latest results.

dotCMS/src/main/java/com/dotmarketing/portlets/contentlet/transform/ContentletTransformer.java

freddyucv · 2022-09-01T16:45:57Z

dotCMS/src/integration-test/java/com/dotcms/contenttype/business/StoryBlockAPITest.java

+                    "                  }\n" +
+                    "               }\n" +
+                    "            ]\n" +
+                    "         }";


maybe we can move this json into a json file

freddyucv · 2022-09-01T16:49:14Z

dotCMS/src/main/java/com/dotcms/contenttype/business/StoryBlockAPIImpl.java

+            });
+        }
+
+        return Tuple.of(refreshed.booleanValue(), contentlet);


should the method throw a exception if contentlet is null?

Maybe include a Precondition that content can't be null

dotCMS/src/main/java/com/dotcms/contenttype/business/StoryBlockAPIImpl.java

dsilvam · 2022-09-01T19:42:04Z

dotCMS/src/main/java/com/dotcms/contenttype/business/StoryBlockAPIImpl.java

+        return Tuple.of(refreshed.booleanValue(), contentlet);
+    }
+    @Override
+    public  Tuple2<Boolean, Object> refreshStoryBlockValueReferences(final Object storyBlockValue) {


dsilvam · 2022-09-01T19:43:30Z

dotCMS/src/main/java/com/dotcms/storage/model/Metadata.java

@@ -24,7 +24,7 @@
 import java.util.Objects;
 import java.util.stream.Collectors;

-public class Metadata implements Serializable {
+    public class Metadata implements Serializable {


this can be removed

…esh-content-editor

…lock editor dependencies

…S/core into issue-22857-refresh-content-editor

…7-refresh-content-editor # Conflicts: # dotCMS/src/integration-test/java/com/dotcms/MainSuite.java # dotCMS/src/main/java/com/dotcms/content/elasticsearch/business/ESContentFactoryImpl.java # dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_field.jsp

* #22857 refreshing block editor contentlet reference (#22867) * #22857 initial draft and ideas * #22857 final changes * ˜#22857 adding the story block api * #22857 the refresh happens now even on cached contentlets * #22857 adding some minor changes * #22857 adding unit test for update references * #22857 unit test for getDependencies * #22857 adding feedback * #22857 adding more feedback * #22857 rolling back some config * #22857 adding some logging * Rename var * #22857 adding a fix for searching by query when need to refresh the block editor dependencies * #22857 adding some flag to control when refresh or not Co-authored-by: Freddy Montes <freddymontes@gmail.com> Co-authored-by: Jose Castro <jose.castro@dotcms.com> * CI: bumps version to 22.12.0-rc.0 [skip ci] * Fix of versions after running code freeze against the release-22.10 branch * Fixing submodules branch * Updating enterprise branch * Revert "Updating enterprise branch" This reverts commit fab861d. * Setting correct dorcmsReleaseVersion property * Updating core-web versions * Publish Release * Update package.json * Update gradle.properties * Update .gitmodules * CI: bumps version to 22.12.0-next.5 [skip ci] Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com> Co-authored-by: Jose Castro <jose.castro@dotcms.com> Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com>

* #22857 initial draft and ideas * #22857 initial draft and ideas * #22857 initial draft and ideas * #22857 initial draft and ideas * #22857 initial draft and ideas * #22857 initial draft and ideas * #22857 final changes * ˜#22857 adding the story block api * #22857 the refresh happens now even on cached contentlets * #22857 adding some minor changes * #22857 adding unit test for update references * #22857 unit test for getDependencies * #22857 unit test for getDependencies * #22857 adding feedback * #22857 adding more feedback * #22857 adding more feedback * #22857 rolling back some config * #22857 rolling back some config * #22857 adding some logging * Rename var * #22857 adding a fix for searching by query when need to refresh the block editor dependencies * #22857 adding some flag to control when refresh or not Co-authored-by: Freddy Montes <freddymontes@gmail.com> Co-authored-by: Jose Castro <jose.castro@dotcms.com>

* #22867 cherry pick done * fixing unit test, a value missing in a msg format

* Fixing artifact plgin invocation. Need to use Gralde version 6.9.3 in order for this to work. * #22864 Categories - $contentlet.categories can be slow * #22864 adding cache for pullAllCategoryChildren * #22864 adding cache for pullAllCategoryChildren * #22864 adding cache for pullAllCategoryChildren * #22864 adding cache for pullAllCategoryChildren * #22864 much faster * Fixing Postman Test: `VanityURL.postman_collection.json` * Removing infinite loop call. Co-authored-by: Jose Castro <jose.castro@dotcms.com> * Trigger builds * CI: bumps version to 22.11.0-rc.5 [skip ci] * CI: bumps version to 22.11.0-rc.16 [skip ci] * #23056 : REVERT - Reverting changes in `docker-compose` files. (#23425) Reverting changes in `docker-compose` files to avoid overwriting important changes already present in `master` branch. Additionally, adding a fix provided by Todd which would add the appropriate `LANG` environment variable when applying the config defaults. * #23296 Bug: WYSIWYG NPE if it finds an invalid data-elements * #23401 Insure zip file integrity * #22857 Keep the contentlets references up to date in the block editor * #22867 cherry pick done * fixing unit test, a value missing in a msg format * CI: bumps version to 22.11.0-rc.6 [skip ci] * Increase version * CI: bumps version to 22.12.0-rc.2 [skip ci] * CI: bumps version to 22.12.0-rc.2 [skip ci] * Increase version rc (#23486) * Increase version rc * Increase version rc * CI: bumps version to 22.12.0-rc.4 [skip ci] * CI: bumps version to 22.13.0-next.3 [skip ci] * CI: bumps version to 23.1.0-next.2 [skip ci] * Fixing merge conflicts in docker-compose files. * Bringing LANG variable back. * CI: bumps version to 23.1.0-next.3 [skip ci] Co-authored-by: Victor Alfaro <victor.alfaro@dotcms.com> Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Jose Castro <jose.castro@dotcms.com> Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>

#22857 initial draft and ideas

3e02f1c

jdotcms added 5 commits August 26, 2022 18:02

#22857 initial draft and ideas

e662762

#22857 initial draft and ideas

70a2df6

#22857 initial draft and ideas

699d6ea

#22857 initial draft and ideas

cbf6f2f

#22857 initial draft and ideas

c68edba

#22857 final changes

938b2ed

jdotcms changed the title ~~#22857 initial draft and ideas~~ #22857 refreshing block editor contentlet reference Aug 29, 2022

wezell reviewed Aug 30, 2022

View reviewed changes

dotCMS/src/main/java/com/dotmarketing/portlets/contentlet/transform/ContentletTransformer.java Outdated Show resolved Hide resolved

jdotcms added 7 commits August 30, 2022 14:34

˜#22857 adding the story block api

3df7c1b

#22857 the refresh happens now even on cached contentlets

f6943a8

#22857 adding some minor changes

b6c60cc

#22857 adding unit test for update references

717a0c3

#22857 unit test for getDependencies

20e3c74

#22857 unit test for getDependencies

ca9d726

#22857 merge master done

d97d420

jdotcms marked this pull request as ready for review September 1, 2022 16:42

freddyucv approved these changes Sep 1, 2022

View reviewed changes

nollymar approved these changes Sep 1, 2022

View reviewed changes

dsilvam reviewed Sep 1, 2022

View reviewed changes

dotCMS/src/main/java/com/dotcms/contenttype/business/StoryBlockAPIImpl.java Show resolved Hide resolved

dsilvam reviewed Sep 1, 2022

View reviewed changes

dotCMS/src/main/java/com/dotcms/contenttype/business/StoryBlockAPIImpl.java Show resolved Hide resolved

dsilvam reviewed Sep 1, 2022

View reviewed changes

jdotcms added 3 commits September 2, 2022 11:50

#22857 adding feedback

99d45de

#22857 adding more feedback

76ea624

#22857 adding more feedback

2adf9bb

jdotcms added 3 commits September 2, 2022 12:05

#22857 rolling back some config

24cd314

#22857 rolling back some config

47b3303

#22857 adding some logging

22a08d3

freddyucv approved these changes Sep 2, 2022

View reviewed changes

jdotcms and others added 6 commits September 7, 2022 22:00

Merge branch 'master' of github.com:dotCMS/core into issue-22857-refr…

8184737

…esh-content-editor

#22857 merge master done

3ffc900

Rename var

27cf06a

#22857 adding a fix for searching by query when need to refresh the b…

d5435b6

…lock editor dependencies

Merge branch 'issue-22857-refresh-content-editor' of github.com:dotCM…

09e5bbf

…S/core into issue-22857-refresh-content-editor

#22857 adding some flag to control when refresh or not

6e71166

fmontes closed this Oct 25, 2022

fmontes reopened this Nov 8, 2022

fmontes changed the base branch from master to release-22.11 November 8, 2022 14:32

fmontes changed the base branch from release-22.11 to release-22.10.1 November 8, 2022 15:22

fmontes merged commit c4ad2ff into release-22.10.1 Nov 9, 2022

fmontes deleted the issue-22857-refresh-content-editor branch November 9, 2022 18:16

jdotcms added a commit that referenced this pull request Nov 28, 2022

#22867 cherry pick done

fc1224e

fmontes pushed a commit that referenced this pull request Dec 1, 2022

#22857 Keep the contentlets references up to date in the block editor

a992fdb

* #22867 cherry pick done * fixing unit test, a value missing in a msg format

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#22857 refreshing block editor contentlet reference #22867

#22857 refreshing block editor contentlet reference #22867

jdotcms commented Aug 26, 2022

github-actions bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

freddyucv Sep 1, 2022

freddyucv Sep 1, 2022

dsilvam Sep 1, 2022

dsilvam Sep 1, 2022

dsilvam Sep 1, 2022

#22857 refreshing block editor contentlet reference #22867

#22857 refreshing block editor contentlet reference #22867

Conversation

jdotcms commented Aug 26, 2022

github-actions bot commented Aug 26, 2022 • edited

Postman Tests Report

github-actions bot commented Aug 26, 2022 • edited

Unit Tests Report

github-actions bot commented Aug 27, 2022 • edited

Integration Tests [postgres] Report

github-actions bot commented Aug 27, 2022 • edited

Integration Tests [mssql] Report

freddyucv Sep 1, 2022

Choose a reason for hiding this comment

freddyucv Sep 1, 2022

Choose a reason for hiding this comment

dsilvam Sep 1, 2022

Choose a reason for hiding this comment

dsilvam Sep 1, 2022

Choose a reason for hiding this comment

dsilvam Sep 1, 2022

Choose a reason for hiding this comment

github-actions bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 26, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited

github-actions bot commented Aug 27, 2022 •

edited