Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Favorite Page: Listing Favorite page contentlets #23058

Closed
Tracked by #22343
alfredo-dotcms opened this issue Sep 29, 2022 · 8 comments · Fixed by #24635 or #23437
Closed
Tracked by #22343

UI - Favorite Page: Listing Favorite page contentlets #23058

alfredo-dotcms opened this issue Sep 29, 2022 · 8 comments · Fixed by #24635 or #23437
Labels
dotCMS : Admin Tools Merged OKR : Core Features Owned by Will QA : Approved QA : Passed Internal Release : 23.06 Team : Lunik Type : Enhancement

Comments

@alfredo-dotcms
Copy link
Contributor

alfredo-dotcms commented Sep 29, 2022 •
edited by nollymar
Loading

Parent Issue

#22343

As a user once I need a new Pages portlet that displays the DotFavoritePage contentlets created and a list of Pages of all the site.

this task only includes the area in the red box

image

Acceptance criteria

  • DotFavoritePages should initially list only 5 items
  • Star icon should be highlighted if the favorite page was created by the user, if it's assigned by an admin then the star icon should not be highlighted
  • PrimeNG Card component needs to be used
  • The order of listing favorite pages should be based on Order field
  • Scope is Only for listing favorite pages, no click interaction will be done

Added more commentaries/notes at the bottom
@nollymar nollymar changed the title UI - Favorite Page: Listing Favorite page contentlest UI - Favorite Page: Listing Favorite page contentlets Oct 6, 2022
@alfredo-dotcms alfredo-dotcms self-assigned this Nov 15, 2022
alfredo-dotcms added a commit that referenced this issue Nov 23, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component
3305f52
alfredo-dotcms added a commit that referenced this issue Nov 25, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - tests
51123a7
alfredo-dotcms added a commit that referenced this issue Nov 28, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - tests
3342444
alfredo-dotcms added a commit that referenced this issue Nov 28, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Added missing doc
5515900
alfredo-dotcms added a commit that referenced this issue Nov 30, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Added Empty State
6ccccd9
alfredo-dotcms added a commit that referenced this issue Nov 30, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Feedback
4309c28
alfredo-dotcms added a commit that referenced this issue Dec 1, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Feedback 2
0707570
alfredo-dotcms added a commit that referenced this issue Dec 1, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Feedback 2
24918b3
alfredo-dotcms added a commit that referenced this issue Dec 1, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Feedback 2
e686cfa
@alfredo-dotcms
Copy link
Contributor Author

More requirements:
image

image

image

@alfredo-dotcms
Copy link
Contributor Author

PR: https://github.com/dotCMS/core/pull/23437/files

alfredo-dotcms added a commit that referenced this issue Dec 2, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component - Feedback 3
0516bae
fmontes pushed a commit that referenced this issue Dec 2, 2022
@alfredo-dotcms
#23058 Favorite Page portlet - listing component (#23437)
88ebbe8 
* #23058 Favorite Page portlet - listing component

* #23058 Favorite Page portlet - listing component - tests

* Update on auto-generated documentation for dotcms-webcomponents

* fix on dot-template-selector.component.spec.ts test failing

* #23058 Favorite Page portlet - listing component - Added missing doc

* #23058 Favorite Page portlet - listing component - Added Empty State

* #23058 Favorite Page portlet - listing component - Feedback

* #23058 Favorite Page portlet - listing component - Feedback 2

* #23058 Favorite Page portlet - listing component - Feedback 3
fmontes pushed a commit that referenced this issue Dec 5, 2022
@alfredo-dotcms
#23060 Click on a Favorite page in Listing portlet should open it in …
c84ce2f 
…Edit Page mode

* #23058 Favorite Page portlet - listing component

* #23058 Favorite Page portlet - listing component - tests

* Update on auto-generated documentation for dotcms-webcomponents

* fix on dot-template-selector.component.spec.ts test failing

* #23058 Favorite Page portlet - listing component - Added missing doc

* #23058 Favorite Page portlet - listing component - Added Empty State

* #23058 Favorite Page portlet - listing component - Feedback

* #23058 Favorite Page portlet - listing component - Feedback 2

* #23060 Click on a Favorite page in Listing portlet should open it in Edit Page mode
@nollymar
Copy link
Contributor

nollymar commented Feb 24, 2023 •
edited
Loading

Internal QA: Needs work

  • When I archive a favorite page, the list is not refreshed
Screen.Recording.2023-02-24.at.4.36.42.PM.mov
  • Besides, if I click on Publish, the context menu displays limited options. It might be related to the non-refreshing behavior reported above
Screen.Recording.2023-02-24.at.4.39.48.PM.mov

@jgambarios
Copy link
Contributor

jgambarios commented Mar 16, 2023 •
edited by alfredo-dotcms
Loading

Internal QA: Needs work

Archive content in Favorites pages grid

2023-03-16_10-40-49.mp4
  1. Error: After archiving the content the grid shows an empty space where the favorite page used to be.
  2. Error: After archiving the content the contextual menu does not work any more.

In order to come back to a normal state the "SEE LESS" button needs to be use to fired a refresh of the component.

Show Archived not working

2023-03-16_10-43-38.mp4
  1. Error: After archiving content from the Favorites grid, the "Show Archived" in the pages list does not display any page.

alfredo-dotcms added a commit that referenced this issue Apr 13, 2023
@alfredo-dotcms
#23058 fix DotPagesPortlet-Show-Archived-status-not-working
bfb8963
@alfredo-dotcms
Copy link
Contributor Author

@jgambarios

@alfredo-dotcms alfredo-dotcms self-assigned this Apr 13, 2023
fmontes pushed a commit that referenced this issue Apr 17, 2023
@alfredo-dotcms
#23058 fix DotPagesPortlet-Show-Archived-status-not-working (#24635)
6d154fe
@fmontes fmontes linked a pull request Apr 17, 2023 that will close this issue
dotCMS/core#23058 fix DotPagesPortlet-Show-Archived-status-not-working #24635
Merged
3 tasks
@jgambarios
Copy link
Contributor

jgambarios commented Apr 17, 2023 •
edited
Loading

As explained in #23058 (comment) the main scope of the ticket is done, some missing behaviors are being tracked in #24561 and #24442

@fmontes fmontes removed this from the 2023.03 milestone Apr 17, 2023
@alfredo-dotcms alfredo-dotcms linked a pull request Apr 17, 2023 that will close this issue
dotCMS/core#23058 Favorite Page portlet - listing component #23437
Merged
3 tasks
@josemejias11
Copy link

Approved QA - Tested on 23.06_2e52dde7_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

@wezell wezell closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : Admin Tools Merged OKR : Core Features Owned by Will QA : Approved QA : Passed Internal Release : 23.06 Team : Lunik Type : Enhancement
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
7 participants
@fmontes @jgambarios @wezell @nollymar @alfredo-dotcms @damen-dotcms @josemejias11