Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotCMS/core#23058 fix DotPagesPortlet-Show-Archived-status-not-working #24635

Merged

Conversation

alfredo-dotcms
Copy link
Contributor

Proposed Changes

  • status icon is not showing the right status, because the ES endpoint only brings attribute archived and not deleted
    image

  • initial ES QUERY to request to load pages is not correct and is missing the query +deleted=false
    image

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@fmontes fmontes merged commit 6d154fe into master Apr 17, 2023
@fmontes fmontes deleted the issue-23058-DotPagesPortlet-Show-Archived-status-not-working branch April 17, 2023 17:10
@fmontes fmontes linked an issue Apr 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Favorite Page: Listing Favorite page contentlets
2 participants