Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container when delete a content type tab it should focus on another #23460

Closed
Tracked by #23140
fmontes opened this issue Nov 29, 2022 · 1 comment
Closed
Tracked by #23140

Container when delete a content type tab it should focus on another #23460

fmontes opened this issue Nov 29, 2022 · 1 comment
Assignees
@zulqarnainvd
Labels
QA : Passed Internal Team : Lunik Type : Enhancement

Comments

@fmontes
Copy link
Member

fmontes commented Nov 29, 2022

Is your feature request related to a problem? Please describe.

When the user is deleting a content type from the code tabs, it should focus on the previous or after.

Describe the solution you'd like

We need to let the user focused on another tab is existed because it gets out of context.

If there is a previous tab we use a tab, if not, we use the next tab if there is no tab left we will have an "empty state" (design coming soon).

Additional context

We need an empty state, I'll be working on this.

Acceptance criteria

  • Users should be able to remove tabs without losing focus of the code component.
@zulqarnainvd zulqarnainvd self-assigned this Dec 8, 2022
zulqarnainvd added a commit that referenced this issue Dec 12, 2022
@zulqarnainvd
#23460 remove content type focus on anothe code if exist or show empt…
104965b 
…y content message
zulqarnainvd added a commit that referenced this issue Dec 12, 2022
@zulqarnainvd
#23460 addd activeTabIndex property from TabView
68eb1b9
zulqarnainvd added a commit that referenced this issue Dec 13, 2022
@zulqarnainvd
#23460 Add and update test cases and fixed tab issues
d190d39
zulqarnainvd added a commit that referenced this issue Dec 13, 2022
@zulqarnainvd
#23460 remove comment
5379a82
zulqarnainvd added a commit that referenced this issue Dec 13, 2022
@zulqarnainvd
#23460 fix typo
5f590c9
zulqarnainvd added a commit that referenced this issue Dec 14, 2022
@zulqarnainvd
#23460 update test cases and work on PR feedbacks
77bb381
fmontes pushed a commit that referenced this issue Dec 14, 2022
@zulqarnainvd
#23460 Container when delete a content type tab it should focus on an…
eec0f7e 
…other

* #23460 remove content type focus on anothe code if exist or show empty content message

* #23460 addd activeTabIndex property from TabView

* #23460 Add and update test cases and fixed tab issues

* #23460 remove comment

* #23460 fix typo

* #23460 update test cases and work on PR feedbacks
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

  • Docker image: master_e37e2c7f

Tabs are focused based on the following criteria:

  • If there's a previous tab, such a tab is selected.
  • If there's NO previous tab, the next tab is selected.
  • If there are NO tabs at all, a help message is displayed.

@fmontes fmontes closed this as completed Dec 16, 2022
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zulqarnainvd zulqarnainvd

Labels
QA : Passed Internal Team : Lunik Type : Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fmontes @jcastro-dotcms @zulqarnainvd