Duplicate Task220825MakeSomeSystemFieldsRemovable but make it better #23736
Assignees
Milestone
Comments
jcastro-dotcms
added a commit
that referenced
this issue
Jan 11, 2023
…locity Var Names Duplicate the `Task220825MakeSomeSystemFieldsRemovable` to use Velocity Var Names instead of Inodes, which is how the previous `Task220825MakeSomeSystemFieldsRemovable` did.
damen-dotcms
changed the title
fmontes
pushed a commit
that referenced
this issue
Jan 20, 2023
…better * #23736: Duplicate `Task220825MakeSomeSystemFieldsRemovable` to use Velocity Var Names Duplicate the `Task220825MakeSomeSystemFieldsRemovable` to use Velocity Var Names instead of Inodes, which is how the previous `Task220825MakeSomeSystemFieldsRemovable` did. * Test for reverting the version of the empty starter for unit tests back to the previous one. * Updating Empty and Full Starters. Updating Base Types instead of specific Content Types. * Fixing error in Integration Test * Checking test results with old empty starter data * Bringing new empty starter back to check test results. * Using old Empty Starter so that tests run correctly.
NOTE FOR IQA AND QAIt's extremely important to make sure that the affected Content Types and their respective fields are updated in both Empty and Full Starters. The list of fields per Base Content Type that must be removable are specified in the description of the following ticket: #15847 (the You can compare the list of removable fields in your test environment with our current Demo Site so that you can see that the trash icon is present now. Here's the list of Content Types that must be reviewed per Starter: Empty Starter:
Full Starter:
|
|
Update from 22.12 > 23.02_SNAPSHOT |
|
This is block by not been able to build a local environment with 23.02 branch https://gist.github.com/josemejias07/15c699eae011573714e07ab088c9874c |
|
We are getting problems when you delete the cache TTL filed from the page asset content type
And we are printing this in the log continuously and it never ends. |
jcastro-dotcms
added a commit
that referenced
this issue
Feb 8, 2023
…t better Return a TTL Cache of zero when the TTL field is not present for a Page content type.
fmontes
pushed a commit
that referenced
this issue
Feb 10, 2023
…better Return a TTL Cache of zero when the TTL field is not present for a Page content type.
fmontes
added
QA : Needs Internal
QA : Passed Internal
and removed
QA : Needs Internal
labels
jcastro-dotcms
added a commit
that referenced
this issue
Feb 16, 2023
fmontes
pushed a commit
that referenced
this issue
Feb 16, 2023
|
Fixed, now this is running and we are able to remove the system fields without problems Tested on release-23.02 // Docker // FF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposed Objective
Accessibility (WCAG)
Proposed Priority
Priority 1 - Show Stopper
dotCMS Version
23.01
Problem Statement
In 23.01 we rolled out a change that allows a site builder to remove a bunch of the unnecessary default content type fields found in our base content types - for example, all File Assets used to require a "show on menu" field. We created a startup task to mark these optional fields as "not required" in the db, but the logic of this startup task hard-coded the structure identifiers that it expected to change, meaning that it only works in the latest starter and not on any content types that were added by a customer.
We need to create a new, almost identical startup task
Task23XXXXMakeSomeSystemFieldsRemovablethat runs the same logic, except this time, change the the requiredness of the fields based on their structures base type, e.g. any content type that is aFile Assetshould have those fields marked as "not required".Steps to Reproduce
Add a custom File Asset type to a dotCMS version < 23.01, and check that the optional fields cannot be removed. Then upgrade. All the optional fields should now be removable.
Acceptance Criteria
Add a custom File Asset type to a dotCMS version < 23.01, and check that the optional fields cannot be removed. Then upgrade. All the optional fields should now be removable.
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Sub-Tasks
No response
Estimates
No response
The text was updated successfully, but these errors were encountered: