Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The spacing in publish and end date are off #23836

Closed
Tracked by #24318
damen-dotcms opened this issue Jan 17, 2023 · 5 comments · Fixed by #25463
Closed
Tracked by #24318

The spacing in publish and end date are off #23836

damen-dotcms opened this issue Jan 17, 2023 · 5 comments · Fixed by #25463
Assignees
@fmontes @zJaaal
Labels
dotCMS : Admin Tools QA : Approved Release : 23.08.16 Team : Lunik Type : Defect

Comments

@damen-dotcms
Copy link
Contributor

Screenshot_2023-01-17_22-20-34.png

Problem Statement

Steps to Reproduce

Acceptance Criteria

Wireframes / Designs / Prototypes

Testing Notes

Assumptions

Estimates

Sub-Tasks

Reported by: Freddy Montes (freddy@dotcms.com)

Source URL: https://demo.dotcms.com/dotAdmin/#/content-types-angular/edit/61226fd915b7f025da020fc1f5856ab7

Issue details: Open in Marker.io

Device typedesktop
BrowserChrome 109.0.0.0
Screen Size3360 x 1890
OSOS X 13.0.0
Viewport Size1553 x 1805
Zoom Level100%
Pixel Ratio@​2x
@fmontes fmontes added the Triage label Feb 23, 2023
@fmontes
Copy link
Member

fmontes commented Feb 23, 2023

I think we should fix all the spacing in the hints and error messages at once.

@fmontes fmontes removed the Triage label Mar 2, 2023
@damen-dotcms damen-dotcms mentioned this issue Mar 8, 2023
Open
@fmontes
Copy link
Member

fmontes commented Jul 7, 2023

And let's fix this:

Image

@zJaaal zJaaal self-assigned this Jul 10, 2023
@zJaaal
Copy link
Contributor

zJaaal commented Jul 10, 2023 •
edited

And let's fix this:

Image

I'll fix this in this PR #25453 #25404 Since I made change here while cleaning the old buttons.

updated
@fmontes

@zJaaal zJaaal linked a pull request Jul 10, 2023 that will close this issue
Fix #23836: Spacing On Date field in Content Types Form #25463
Merged
@zJaaal
Copy link
Contributor

zJaaal commented Jul 10, 2023

And let's fix this:
Image

I'll fix this in this PR #25453 #25404 Since I made change here while cleaning the old buttons.

updated @fmontes

Screenshot 2023-07-10 at 6 30 30 PM

Fixed!

fmontes pushed a commit that referenced this issue Jul 11, 2023
@zJaaal
Fix #23836: Spacing On Date field in Content Types Form (#25463)
8cc0f17 
* fix spacing in helper text

* made styles more specific

* fix gap between field when dateVarOptions exists
@fmontes fmontes self-assigned this Jul 13, 2023
@josemejias11
Copy link

Approved QA - Tested on master_62f34b0_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmontes fmontes

@zJaaal zJaaal

Labels
dotCMS : Admin Tools QA : Approved Release : 23.08.16 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #23836: Spacing On Date field in Content Types Form dotCMS/core
4 participants
@fmontes @zJaaal @damen-dotcms @josemejias11