Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to easily preview URL Mapped Content #23955

Closed
wezell opened this issue Jan 31, 2023 · 5 comments · Fixed by #24025
Closed

Allow user to easily preview URL Mapped Content #23955

wezell opened this issue Jan 31, 2023 · 5 comments · Fixed by #24025
Assignees
@zulqarnainvd
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will OKR : User Experience Owned by Jason QA : Approved QA : Passed Internal Release : 23.01.8 Included in LTS patch release 23.01.8 Release : 23.03 Team : Lunik
Milestone
2023.03

Comments

@wezell
Copy link
Contributor

wezell commented Jan 31, 2023

User Story

If a user is editing a html page content, they get a "preview" button that will take them directly to the page they are editing in edit mode. We need to add the same link for content that has url maps.

Screen Shot 2023-01-31 at 11 49 14 AM

Acceptance Criteria

When saving a new urlmapped content, a preview button should become available, When clicked, a new tab should open with the urlmapped content displayed on it.

We will need to test how this works for url-mapped content that lives on the system host

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response
wezell added a commit that referenced this issue Jan 31, 2023
@wezell
#23955 adds preview button
059b9f0
@fmontes fmontes linked a pull request Feb 2, 2023 that will close this issue
dotCMS/core#23955 Allow user to easily preview URL Mapped Content #24025
Merged
3 tasks
@fmontes
Copy link
Member

fmontes commented Feb 2, 2023

TODO:

  • Add the link to /dotAdmin/#/edit-page/content?url=${PAGE_DETAIL}/${SLUG}
  • Get the page detail from the backend.

zulqarnainvd added a commit that referenced this issue Feb 13, 2023
@zulqarnainvd
#23955 open page preview on new tab
e848508
@fmontes
Copy link
Member

fmontes commented Feb 14, 2023

If the content is new (never been saved) we have to hide the button.

zulqarnainvd added a commit that referenced this issue Feb 15, 2023
@zulqarnainvd
#23955 show preview button only when content url link is available
f2db170
fmontes added a commit that referenced this issue Feb 21, 2023
@fmontes @wezell @zulqarnainvd
#23955 Allow user to easily preview URL Mapped Content (#24025)
8d7b0f2 
* #23955 adds preview button

* #23955 open page preview on new tab

* #23955 show preview button only when content url link is available

---------

Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: Zulqarnain <zulqarnain.huda@venturedive.com>
Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>
@fmontes fmontes reopened this Feb 21, 2023
@fmontes
Copy link
Member

fmontes commented Feb 21, 2023

  1. Create the page will not show the button
  2. Edit the page will show the button.
  3. Includes urlMapped pages, like blogs

@fmontes fmontes added this to the 2023.03 milestone Feb 24, 2023
@josemejias07
Copy link

Approved QA - Tested on 23.03_5108019d_SNAPSHOT // Docker // macOS 13.0 // FF v110.0

@wezell wezell closed this as completed May 12, 2023
@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Aug 30, 2023
@binarybasher
Copy link

Is this due for release in v23.1.7 LTS ?

erickgonzalez added a commit that referenced this issue Oct 30, 2023
@erickgonzalez
#23955 include in 23.01.8
acf41b0
@erickgonzalez erickgonzalez added Release : 23.01.8 Included in LTS patch release 23.01.8 LTS: Excluded Ticket that has been excluded from at least one LTS and removed LTS : Next Ticket that will be added to LTS labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zulqarnainvd zulqarnainvd

Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will OKR : User Experience Owned by Jason QA : Approved QA : Passed Internal Release : 23.01.8 Included in LTS patch release 23.01.8 Release : 23.03 Team : Lunik
Projects
dotCMS - Product Planning
Archived in project
Milestone
2023.03
Development

Successfully merging a pull request may close this issue.

dotCMS/core#23955 Allow user to easily preview URL Mapped Content dotCMS/core
6 participants
@fmontes @wezell @binarybasher @erickgonzalez @josemejias07 @zulqarnainvd