Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotCMS/core#23955 Allow user to easily preview URL Mapped Content #24025

Merged
merged 4 commits into from Feb 21, 2023

Conversation

fmontes
Copy link
Member

@fmontes fmontes commented Feb 2, 2023

Proposed Changes

  • Open Preview on new tab

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

@fmontes fmontes linked an issue Feb 2, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Unit Tests Report

1 418 tests  ±0   1 408 ✔️ ±0   4m 19s ⏱️ +26s
   140 suites ±0        10 💤 ±0 
   140 files   ±0          0 ±0 

Results for commit f2db170. ± Comparison against base commit 66f18ad.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Postman Tests Report

     65 files  ±0  1 397 suites  ±0   3h 13m 51s ⏱️ + 4m 3s
   625 tests ±0     623 ✔️ ±0  0 💤 ±0  2 ±0 
2 331 runs  ±0  2 324 ✔️ ±0  0 💤 ±0  7 ±0 

For more details on these failures, see this check.

Results for commit f2db170. ± Comparison against base commit 66f18ad.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Integration Tests [postgres] Report

   409 files  ±0     409 suites  ±0   1h 17m 20s ⏱️ - 10m 8s
3 900 tests ±0  3 876 ✔️ +1  23 💤 ±0  1  - 1 
3 921 runs  ±0  3 897 ✔️ +1  23 💤 ±0  1  - 1 

For more details on these failures, see this check.

Results for commit f2db170. ± Comparison against base commit 66f18ad.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Integration Tests [mssql] Report

   408 files  ±0     408 suites  ±0   2h 9m 28s ⏱️ - 20m 56s
3 895 tests ±0  3 855 ✔️ ±0  23 💤 ±0  17 ±0 
3 916 runs  ±0  3 876 ✔️ ±0  23 💤 ±0  17 ±0 

For more details on these failures, see this check.

Results for commit f2db170. ± Comparison against base commit 66f18ad.

♻️ This comment has been updated with latest results.

<div class="content-edit-actions" >
<a style="border:0px;" onClick="editPage('<%= APILocator.getIdentifierAPI().find(contentlet.getIdentifier()).getURI() %>', '<%= contentlet.getLanguageId() %>')">
<a style="border:0px;" href="<%= previewUrl %>" target="_blank">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you are creating a page from content search the buttons shows and if you click it it throws a 404, we should only show the button when the page actually exist.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmontes fmontes merged commit 8d7b0f2 into master Feb 21, 2023
@fmontes fmontes deleted the issue-23955-preview-urlmaps branch February 21, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to easily preview URL Mapped Content
3 participants