Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a video's thumbnail component #24040

Closed
2 tasks
Tracked by #21988
rjvelazco opened this issue Feb 6, 2023 · 5 comments · Fixed by #24077 or #24097
Closed
2 tasks
Tracked by #21988

Create a video's thumbnail component #24040

rjvelazco opened this issue Feb 6, 2023 · 5 comments · Fixed by #24077 or #24097
Assignees
@rjvelazco
Labels
Priority : 3 Average QA : Approved QA : Passed Internal Release : 23.03 Team : Lunik Type : Enhancement

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Feb 6, 2023 •
edited

User Story

As a user, I want to be able to preview video thumbnails, so I can see what video I'm going to choose.

Acceptance Criteria

  • Create a component (in the web-component library) that allows you to display the video's thumbnail.
  • Make sure the component is responsive.
  • Allow users to disable the video thumbnails with a SHOW_VIDEO_THUMBNAIL=false dotmatketing property.

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

We have to make sure that the component accepts the width and height as parameters.

Sub-Tasks & Estimates

No response

Tasks
Beta Give feedback

Tasks
Beta Give feedback
@rjvelazco rjvelazco self-assigned this Feb 6, 2023
rjvelazco added a commit that referenced this issue Feb 9, 2023
@rjvelazco
dev: create a video thumbnail component #24040
d20b7d0
fmontes pushed a commit that referenced this issue Feb 13, 2023
@rjvelazco
#24040 Create a video's thumbnail component (#24077)
41c2c60 
* dev: create a video thumbnail component #24040

* dev: use thumbnail component in block editor

* clean up

* clean up v2

* dev: remove fdescribe

* dev: update editor
@fmontes
Copy link
Member

fmontes commented Feb 13, 2023

Vertical videos do a bad resize for the card.

image

@rjvelazco
Copy link
Contributor Author

PR: #24097

@fmontes
Copy link
Member

fmontes commented Feb 15, 2023

Let's add this behind in a dotmarketing property.

@fmontes fmontes mentioned this issue Feb 16, 2023
Closed
fmontes pushed a commit that referenced this issue Feb 16, 2023
@rjvelazco
#24040 Create a video's thumbnail component (#24097)
e4a3d0e 
* dev: fix vertial videos thumbnail

* dev: Show/hide thumbnails based on the dotmarketing SHOW_VIDEO_THUMBNAIL property

* clean up

* clean up v2

* clean up v2

* remove 'fit'
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

By default, video thumbnails are being generated now. The steps to reproduce are the following:

  1. Do a simple screen recording. In Mac, just hit CMD + shift + 5 to record your screen or parts of it.
  2. Go to the Content Search portlet, and upload the video as a File Asset.
  3. Go back to the Content Search, and change the view from List to Grid -- top-left corner of the portlet.
  4. Your video's thumbnail must show up.

@josemejias07
Copy link

Approved QA - Tested on 23.03_5108019d_SNAPSHOT // Docker // macOS 13.0 // FF v110.0

@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
This was linked to pull requests Mar 7, 2023
dotCMS/core#24040 Create a video's thumbnail component #24077
Merged
dotCMS/core#24040 Create a video's thumbnail component #24097
Merged
@wezell wezell closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

Labels
Priority : 3 Average QA : Approved QA : Passed Internal Release : 23.03 Team : Lunik Type : Enhancement
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
6 participants
@fmontes @wezell @jcastro-dotcms @rjvelazco @josemejias07 @damen-dotcms