Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotCMS/core#24040 Create a video's thumbnail component #24077

Merged
merged 7 commits into from Feb 13, 2023
Merged

dotCMS/core#24040 Create a video's thumbnail component #24077

merged 7 commits into from Feb 13, 2023

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Feb 9, 2023 •
edited

Proposed Changes

  • Create a video thumbnail web component.
  • Implement the component in the Content Search view and Block Editor.

Checklist

  • Tests
  • Translations (Not apply)
  • Security Implications Contemplated (add notes if applicable)

Additional Info

To create the thumbnail, we don't load the whole video, we load the first frame.

Screenshots

Original Updated
no-thumbnail thumbnail

Block Editor

video-thumbnail-block-editor

@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited

Unit Tests Report

0 tests   - 1 418   0 ✔️  - 1 408   0s ⏱️ - 3m 59s
0 suites  -    140   0 💤  -      10 
0 files    -    140   0 ❌ ±       0 

Results for commit 87dc95a. ± Comparison against base commit 399334a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited

Postman Tests Report

     65 files  ±0  1 397 suites  ±0   3h 10m 14s ⏱️ - 4m 53s
   625 tests ±0     623 ✔️ +4  0 💤 ±0  2 ❌  - 4 
2 331 runs  ±0  2 324 ✔️ +6  0 💤 ±0  7 ❌  - 6 

For more details on these failures, see this check.

Results for commit 87dc95a. ± Comparison against base commit 399334a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited

Integration Tests [postgres] Report

   409 files  ±0     409 suites  ±0   1h 9m 0s ⏱️ + 1m 20s
3 900 tests ±0  3 876 ✔️ ±0  23 💤 ±0  1 ❌ ±0 
3 921 runs  ±0  3 897 ✔️ ±0  23 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 87dc95a. ± Comparison against base commit 399334a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited

Integration Tests [mssql] Report

0 files   -    408  0 suites   - 408   0s ⏱️ - 2h 49m 15s
0 tests  - 3 894  0 ✔️  - 3 860  0 💤  - 23  0 ❌  - 11 
0 runs   - 3 915  0 ✔️  - 3 881  0 💤  - 23  0 ❌  - 11 

Results for commit d10dafd. ± Comparison against base commit 00af9c3.

♻️ This comment has been updated with latest results.

@rjvelazco rjvelazco requested review from oidacra, fmontes and hmoreras and removed request for oidacra, fmontes and hmoreras February 10, 2023 13:35
@rjvelazco rjvelazco marked this pull request as ready for review February 10, 2023 13:35
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmontes fmontes merged commit 41c2c60 into master Feb 13, 2023
@fmontes fmontes deleted the issue-24040-create-a-videos-thumbnail-component-mt branch February 13, 2023 20:08
@rjvelazco rjvelazco linked an issue Mar 7, 2023 that may be closed by this pull request
Create a video's thumbnail component #24040
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmontes fmontes fmontes approved these changes

@oidacra oidacra oidacra approved these changes

@manuelrojas manuelrojas Awaiting requested review from manuelrojas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a video's thumbnail component
3 participants
@rjvelazco @fmontes @oidacra