Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containers] : Clicking up or down arrows in Max Contents field is not working #24163

Closed
Tracked by #23140
jcastro-dotcms opened this issue Feb 17, 2023 · 9 comments · Fixed by #24177
Closed
Tracked by #23140

Comments

@jcastro-dotcms
Copy link
Contributor

Problem Statement

When you create a Container and lick the up arrow in the Max Contents field, none of the pre-loop, code or post-loop fields show up. They only way to make them show up is by manually typing in a value in such a field.

Steps to Reproduce

  1. Go to the new Containers portlet: http://localhost:8080/dotAdmin/#/containers and create a new Container.
  2. Click the up arrow in the Max Contents field.
  3. The UI never changes, and you only see the Code field.

Acceptance Criteria

The pre-loop, code or post-loop fields must show up as soon as the value of the Max Contents field is greater than zero.

dotCMS Version

Latest master.

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Found during IQA of #23443

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response

@rjvelazco
Copy link
Contributor

Passed Internal QA

Docker Image: [dotcms/dotcms:master_bd915908]

containers-clicking-up-or-down-arros-in-max-contents-fields-is-not-working.mov

Note:

I also test the case where the Max Contents Field is greater than 1 and it's working as the Old Portlet.

@josemejias07
Copy link

Failed QA - Tested on 23.03_5ce847f3_SNAPSHOT // Docker // macOS 13.0 // FF v110.0

The Up/Down arrows selection was deleted. We need to maintain previous functionality.

Screen.Recording.2023-03-03.at.12.06.35.PM.mov

@fmontes
Copy link
Member

fmontes commented Mar 10, 2023

@josemejias07 checked in master and I see the numbers, also if you inspect the code in that field you will see that is type="number" which is the attr that makes that behaviour, please double check:

Image

@bryanboza
Copy link
Member

@josemejias07 this is not merged to the release branch, you are testing this on 23.03_5ce847f3_SNAPSHOT.

@josemejias07
Copy link

josemejias07 commented Mar 29, 2023

Not in Master

@josemejias07 josemejias07 self-assigned this Mar 29, 2023
@josemejias07
Copy link

Failed QA - Tested on 23.05_becff921_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

@rjvelazco
Copy link
Contributor

rjvelazco commented Apr 4, 2023

@josemejias07 This issue was created for the new Container Portlet: http://localhost:8080/dotAdmin/#/containers, where the arrows for the Max Contents field weren't working as expected.

From what I can tell based on the video, it was tested on the old portlet version: https://demo.dotcms.com/dotAdmin/#/c/containers instead of the new one http://localhost:8080/dotAdmin/#/containers.

I don't think we have ever had arrows in the Max Contents field of the old portlet -I might be wrong-.

@rjvelazco
Copy link
Contributor

What are your thoughts @bryanboza @fmontes? Should we add the arrows in the Max Contents field of the old portlet in this card or create a new one for it?

@josemejias11
Copy link

josemejias11 commented Apr 12, 2023

Approved QA - Tested on 23.05_8308316d_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

https://localhost:8443/dotAdmin/#/containers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment