dotCMS/core#24163 [Containers] : Clicking up or down arrows in Max Contents field is not working #24177
Conversation
screen-capture.10.webm |
screen-capture.9.webm |
|
updated |
| @@ -54,8 +54,7 @@ export class DotContainerPropertiesComponent implements OnInit, AfterViewInit { | |||
| title: new FormControl(container?.title ?? '', [Validators.required]), | |||
| friendlyName: new FormControl(container?.friendlyName ?? ''), | |||
| maxContentlets: new FormControl(container?.maxContentlets ?? 0, { | |||
| validators: [Validators.required], | |||
| updateOn: 'blur' | |||
| validators: [Validators.required] | |||
There was a problem hiding this comment.
is there a way to test this?
There was a problem hiding this comment.
Is this going to be triggered on every change of the field? is so... we need to catch that somehow.
There was a problem hiding this comment.
@zulqarnainvd Isn't this updating the UI several time after it goes from 1 to 2 and 3 etc? I mean... we should only change tha state when 0 or 1. Can you double check that?
| @@ -54,8 +54,7 @@ export class DotContainerPropertiesComponent implements OnInit, AfterViewInit { | |||
| title: new FormControl(container?.title ?? '', [Validators.required]), | |||
| friendlyName: new FormControl(container?.friendlyName ?? ''), | |||
| maxContentlets: new FormControl(container?.maxContentlets ?? 0, { | |||
| validators: [Validators.required], | |||
| updateOn: 'blur' | |||
| validators: [Validators.required] | |||
There was a problem hiding this comment.
Is this going to be triggered on every change of the field? is so... we need to catch that somehow.
|
SonarQube Quality Gate
|
| @@ -54,8 +54,7 @@ export class DotContainerPropertiesComponent implements OnInit, AfterViewInit { | |||
| title: new FormControl(container?.title ?? '', [Validators.required]), | |||
| friendlyName: new FormControl(container?.friendlyName ?? ''), | |||
| maxContentlets: new FormControl(container?.maxContentlets ?? 0, { | |||
| validators: [Validators.required], | |||
| updateOn: 'blur' | |||
| validators: [Validators.required] | |||
There was a problem hiding this comment.
@zulqarnainvd Isn't this updating the UI several time after it goes from 1 to 2 and 3 etc? I mean... we should only change tha state when 0 or 1. Can you double check that?
|
@fmontes I checked old container you can type any number you want. On the other hand it is only update the store when previous Max Contents greater than zero or previous value null. I added a screenshot below so you can verify.
|
fmontes
deleted the
24163-containers-clicking-up-or-down-arrows-in-max-contents-field-is-not-working
branch
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots