Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Containers] : Save button is disables under specific circumstances #24164

Closed
Tracked by #23140
jcastro-dotcms opened this issue Feb 17, 2023 · 2 comments · Fixed by #24178
Closed
Tracked by #23140

[Containers] : Save button is disables under specific circumstances #24164

jcastro-dotcms opened this issue Feb 17, 2023 · 2 comments · Fixed by #24178
Assignees
@zulqarnainvd
Labels
dotCMS : Content Management QA : Approved QA : Passed Internal Team : Lunik Type : Defect

Comments

@jcastro-dotcms
Copy link
Contributor

Problem Statement

The SAVE button is not being enabled when trying to add a new Content Type to a new Container.

Steps to Reproduce

  1. Go to the new Containers portlet: http://localhost:8080/dotAdmin/#/containers and create a new Container.
  2. Type in "1" in the Max Contents field, so that the Content Type Code field shows up.
  3. Click the "+" button and add the Contact content type.
  4. Type in any code in there.
  5. The SAVE button is not enabled. Even if you try to change the Container's name or description, it remains disabled.

Acceptance Criteria

The SAVE button must be enabled after any change is made.

dotCMS Version

Latest master.

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Found during IQA of #23443

Assumptions & Initiation Needs

If you type in any characters for the default Activity content type, then the SAVE button is enabled. This is the only way to make it work. So there seems to be a problem with JS events at some point?

Sub-Tasks & Estimates

No response
@jcastro-dotcms jcastro-dotcms mentioned this issue Feb 17, 2023
Closed
2 tasks
@zulqarnainvd zulqarnainvd self-assigned this Feb 22, 2023
zulqarnainvd added a commit that referenced this issue Feb 22, 2023
@zulqarnainvd
#24164 remove required from code field
52ba4d6
zulqarnainvd added a commit that referenced this issue Feb 24, 2023
@zulqarnainvd
#24164 update test cases
217064e
zulqarnainvd added a commit that referenced this issue Feb 24, 2023
@zulqarnainvd
#24164 add default content type code test case
db3bb15
@fmontes fmontes linked a pull request Feb 25, 2023 that will close this issue
dotCMS/core#24164 [Containers] : Save button is disables under specific circumstances #24178
Merged
3 tasks
zulqarnainvd added a commit that referenced this issue Feb 28, 2023
@zulqarnainvd
#24164 add test case
6996f1b
fmontes pushed a commit that referenced this issue Feb 28, 2023
@zulqarnainvd
#24164 [Containers] : Save button is disables under specific circumst…
b97f96b 
…ances (#24178)

* #24164 remove required from code field

* #24164 update test cases

* #24164 add default content type code test case

* #24164 add test case
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
@rjvelazco
Copy link
Contributor

Passed Internal QA

Docker Image: [dotcms/dotcms:master_bd915908]

save-button-must-be-enabled-after-any-change.mov

@josemejias07
Copy link

Approved QA - Tested on 23.03_5ce847f3_SNAPSHOT // Docker // macOS 13.0 // FF v110.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zulqarnainvd zulqarnainvd

Labels
dotCMS : Content Management QA : Approved QA : Passed Internal Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dotCMS/core#24164 [Containers] : Save button is disables under specific circumstances dotCMS/core
6 participants
@fmontes @jcastro-dotcms @rjvelazco @josemejias07 @zulqarnainvd @damen-dotcms