Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block editor add video.vtl to render a video by default #24465

Closed
1 of 3 tasks
fmontes opened this issue Mar 23, 2023 · 1 comment · Fixed by #24555
Closed
1 of 3 tasks

Block editor add video.vtl to render a video by default #24465

fmontes opened this issue Mar 23, 2023 · 1 comment · Fixed by #24555
Assignees
Labels

Comments

@fmontes
Copy link
Member

fmontes commented Mar 23, 2023

Parent Issue

#21988

User Story

As a user I want to be able to render videos our of the box in dotCMS block editor

Acceptance Criteria

  • Rename video-node to dotVideo
  • Add a dotVideo.vtl to dotCMS/src/main/webapp/WEB-INF/velocity/static/storyblock/dotImage.vtl
  • Render video using the <video>

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Here is how we render images

<div style="text-align: $!item.attrs.textAlign">

    #if ($!item.attrs.href != "null")
    <a href="$!item.attrs.href">
    #end
        <img
            src="#if($!item.attrs.src && $!item.attrs.src != "null")$!item.attrs.src#{else}$!item.attrs.data.asset#end"
            alt="#if($!item.attrs.alt && $!item.attrs.alt != "null")$!item.attrs.alt#{else}$!item.attrs.data.title#end"
            title="#if($!item.attrs.title && $!item.attrs.title != "null")$!item.attrs.title#{else}$!item.attrs.data.title#end"
        />
    #if ($!item.attrs.href != "null")
    </a>
    #end

</div>

So you can have an idea for video.

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@josemejias11
Copy link

Approved QA - Tested on 23.05_accf5f2d_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

erickgonzalez added a commit that referenced this issue May 23, 2023
@erickgonzalez erickgonzalez added LTS: Excluded Ticket that has been excluded from at least one LTS Release : 23.01.3 Included in LTS patch release 23.01.3 labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants