Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block editor add video.vtl to render a video by default#24465 #24555

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Apr 4, 2023

Proposed Changes

  • Create video.vtl and youtube.vtl files.

Screenshots

fix-issue-24465-block-editor-add-videovtl-to-render-a-video-by-default.mov

🤖 Generated by Copilot at 0dd40de

Summary

🎥🛠️🌐

Added support for YouTube videos as a new block type in the block editor and the frontend. Created youtube.vtl and dotVideo.vtl templates to render the videos and updated parser.utils.ts to recognize the youtube block type.

Add youtube blocks
To the block editor with
imageContent function

Walkthrough

  • Add support for YouTube videos as content blocks in the block editor (link, link)
  • Update imageContent function to include youtube as a valid block type (link)
  • Create youtube.vtl template to render the youtube block type in the frontend (link)
  • Add support for custom video sources as content blocks in the block editor (link)
    • Create dotVideo.vtl template to render the dotVideo block type in the frontend (link)

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Unit Tests Report

1 423 tests  ±0   1 413 ✔️ ±0   3m 59s ⏱️ +6s
   140 suites ±0        10 💤 ±0 
   140 files   ±0          0 ±0 

Results for commit 3441464. ± Comparison against base commit 99416d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Postman Tests Report

     66 files  ±0  1 412 suites  ±0   3h 44m 33s ⏱️ + 7m 19s
   632 tests ±0     626 ✔️  - 1  0 💤 ±0  6 +1 
2 348 runs  ±0  2 340 ✔️  - 1  0 💤 ±0  8 +1 

For more details on these failures, see this check.

Results for commit 0dd40de. ± Comparison against base commit 86e392f.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Integration Tests [postgres] Report

   410 files  ±0     410 suites  ±0   1h 36m 34s ⏱️ + 3m 23s
3 944 tests ±0  3 918 ✔️  - 1  23 💤 ±0  3 +1 
3 963 runs  ±0  3 937 ✔️  - 1  23 💤 ±0  3 +1 

For more details on these failures, see this check.

Results for commit 0dd40de. ± Comparison against base commit 86e392f.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Integration Tests [mssql] Report

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 0dd40de. ± Comparison against base commit 86e392f.

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rjvelazco rjvelazco merged commit 61e0d05 into release-23.05 Apr 5, 2023
18 of 22 checks passed
@rjvelazco rjvelazco deleted the issue-24465-block-editor-add-videovtl-to-render-a-video-by-default branch April 5, 2023 16:01
@rjvelazco rjvelazco linked an issue Apr 5, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block editor add video.vtl to render a video by default
4 participants