-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block editor add video.vtl to render a video by default#24465 #24555
Merged
rjvelazco
merged 3 commits into
release-23.05
from
issue-24465-block-editor-add-videovtl-to-render-a-video-by-default
Apr 5, 2023
Merged
Block editor add video.vtl to render a video by default#24465 #24555
rjvelazco
merged 3 commits into
release-23.05
from
issue-24465-block-editor-add-videovtl-to-render-a-video-by-default
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
approved these changes
Apr 4, 2023
hmoreras
approved these changes
Apr 5, 2023
SonarQube Quality Gate 0 Bugs No Coverage information |
SonarQube Quality Gate |
manuelrojas
approved these changes
Apr 5, 2023
rjvelazco
deleted the
issue-24465-block-editor-add-videovtl-to-render-a-video-by-default
branch
April 5, 2023 16:01
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
video.vtl
andyoutube.vtl
files.Screenshots
fix-issue-24465-block-editor-add-videovtl-to-render-a-video-by-default.mov
🤖 Generated by Copilot at 0dd40de
Summary
🎥🛠️🌐
Added support for YouTube videos as a new block type in the block editor and the frontend. Created
youtube.vtl
anddotVideo.vtl
templates to render the videos and updatedparser.utils.ts
to recognize theyoutube
block type.Walkthrough
imageContent
function to includeyoutube
as a valid block type (link)youtube.vtl
template to render theyoutube
block type in the frontend (link)dotVideo.vtl
template to render thedotVideo
block type in the frontend (link)