Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor Video Node MimeType Property Typo #24556

Closed
rjvelazco opened this issue Apr 4, 2023 · 2 comments · Fixed by #24557
Closed

Block Editor Video Node MimeType Property Typo #24556

rjvelazco opened this issue Apr 4, 2023 · 2 comments · Fixed by #24557

Comments

@rjvelazco
Copy link
Contributor

Parent Issue

#23863

Problem Statement

In the block editor video node json. The property is called mineType which is a typo, while in dotAsset the property is called mimeType which is the correct name.

in block editor:

{
  "type": "dotVideo",
  "attrs": {
    "src": "/dA/3f6ba3f29edc30313a922179fa43acd5/asset/dotCMS - Remote block editor extensions.mp4",
    "mineType": "application/mp4",
    ...
  }
}

dotAsset:

{
  "contentlets": [
    {
      "publishDate": "2023-03-31 18:25:48.926",
      "assetContentAsset": "3f6ba3f29edc30313a922179fa43acd5/asset",
      "mimeType": "video/mp4",
      ...
    }
  ]
}

Steps to Reproduce

  1. Go to any blog.
  2. Add a video.
  3. Get the blog content.
  4. Look for the blogContent property.
  5. See the Video Node Block, there a mineType property.
Screen.Recording.2023-04-04.at.3.03.03.PM.mov

Acceptance Criteria

Rename the property from mineType to mimeType in the video node json.

dotCMS Version

Release-23.05

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.slack.com/archives/CQQMX585N/p1680619492805539

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@manuelrojas
Copy link
Contributor

Passed Internal QA
Docker Image: [dotcms/dotcms:23.05_9344a860_SNAPSHOT]

image

@bryanboza
Copy link
Member

Fixed, tested on release-23.05 // Docker // FF

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment