Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bock Editor: Allow user to insert videos from local files #23863

Closed
Tracked by #21988
fmontes opened this issue Jan 20, 2023 · 16 comments · Fixed by #24248, #23933, #24338, #24374 or #24417
Closed
Tracked by #21988

Bock Editor: Allow user to insert videos from local files #23863

fmontes opened this issue Jan 20, 2023 · 16 comments · Fixed by #24248, #23933, #24338, #24374 or #24417
Assignees
@rjvelazco
Labels
Doc : Needs Doc LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will QA : Approved Release : 23.01.3 Included in LTS patch release 23.01.3 Release : 23.03 Team : Lunik

Comments

@fmontes
Copy link
Member

fmontes commented Jan 20, 2023 •
edited

User Story

As a user, I want to be able to insert an videos from my local files to the editor.

How it works?

  1. Add tabs to the image panel
  2. The first tab will be for the current approach and the second will be for this task, uploading videos from the local files.
  3. When user clicks "Upload" it will open the file system window to browse for an image
  4. After user select the image we upload as dotAsset and inserted, the same approach that we do when user drops an image in the editor.

Acceptance Criteria

  • User should be able to insert an video from it local files
  • Make sure the functionality of adding videos from dotCMS doesn't breaks.

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response
@fmontes
Copy link
Member Author

fmontes commented Feb 16, 2023

Done here: #23933

@fmontes fmontes closed this as completed Feb 16, 2023
@fmontes fmontes reopened this Feb 16, 2023
@fmontes fmontes closed this as completed Feb 16, 2023
@fmontes fmontes reopened this Feb 16, 2023
@josemejias07
Copy link

Failed QA - Tested on 23.03_5108019d_SNAPSHOT // Docker // macOS 13.0 // FF v110.0

  1. Video upload shows a warning of not allowing videos bigger than 1mb to be uploaded, however the video can be uploaded
  2. Video should fit the size of the container to a maximum size. Currently we are showing the video to full size.
Video_Upload.mov

@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
rjvelazco added a commit that referenced this issue Mar 1, 2023
@rjvelazco
dev: remove fileSize limit and fit the video in the block editor #23863
c55514a
@rjvelazco rjvelazco mentioned this issue Mar 1, 2023
Merged
@rjvelazco
Copy link
Contributor

PR: #24248

@rjvelazco rjvelazco linked a pull request Mar 1, 2023 that will close this issue
Bock Editor: Allow user to insert videos from local files #23863 #24248
Merged
fmontes pushed a commit that referenced this issue Mar 6, 2023
@rjvelazco
Bock Editor: Allow user to insert videos from local files#23863 (#24248)
bf41437 
* dev: remove fileSize limit and fit the video in the block editor #23863

* clean up
@rjvelazco rjvelazco linked a pull request Mar 7, 2023 that will close this issue
dotCMS/core#23436 Block Editor: Create video block node and insert from dotCMS content #23933
Merged
fmontes added a commit that referenced this issue Mar 9, 2023
@jcastro-dotcms @victoralfaro-dotcms
@rjvelazco @alfredo-dotcms @fmontes @manuelrojas @zulqarnainvd @hassan-mustafa-baig @wezell
Merging latest release-23.03 into master - PR3 (#24322)
e3b2916 
* Update release version for dotcms-ui and dotcms-webcomponents

* Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03

* Update branch in git submodule to release-23.03

* Excluding from triggering test at folder: dotCMS/src/main/webapp/html

* #23977 Block editor freeze scroll on tippy menus show (#24180)

* dev: freeze scroll on show forms #23977

* clean up

* refactor

* clean up v2

* feedback

* clean up

* #24172 Refresh Page portlet's data when site changed (#24175)

* #24031 fix block editor not saving (#24222)

* Fix #24032 Bring it to 22.03 (#24229)

* Fix #24032 Bring it to 22.03

* Build de lib

---------

Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>

* #24240 Fix data-access tests in 23.03 (#24244)

* #24240 fix test cases

* #24240 fix lint

* fire release docker image generation

* #24221 fix Snapshots should be displayed when the language is changed (#24234)

* Fix #23449 show dotAssets in folder listing

* Bock Editor: Allow user to insert videos from local files#23863 (#24248)

* dev: remove fileSize limit and fit the video in the block editor #23863

* clean up

* Fix 24032: Adding for Internal QA (#24255)

* #24032 Adding Fix for Internal QA

* #24032 Adding PR Feedback

* #24032 Adding PR Feedback

* #24032 Adding PR Feedback

* #24032 Logging error

* dotCMS/core#issue-20432 adding const

* dotCMS/core#issue-20432 adding const

* #24032 validation schema

* Adding empty extensions

* Adding empty extensions

* Get all modules no actions required

* Adding optional validation for actions

* Adding optional validation for actions

* Adding id insted of name

* Adding Type for promise

* Adding dot-cms-block-editor

* Adding lock file

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #22151 make the message better (#24041)

* #22151 make the message better

* #22151 hides token button if aws

* #24173 Create dialog for 'Create Page' button (#24215)

* #24173 Create dialog for 'Create Page' button

* #24173 Create dialog for 'Create Page' button - tests

* #24173 Create dialog for 'Create Page' button - feedback

* #24173 Create dialog for 'Create Page' button - more feedback

* #23901 fixes the git hash resolution (#23902)

* #23889 fixed content permission load issue (#24296)

* #24308 Can't search for contentlets in edit page palette (#24316)

* #24308 fixed contentlets search

* #24308 refactor test case

* #24308 refactor code

* Update package-lock

* Fix versioning

* Fix versioning and FE tests

* Build

* Add line

* Had to dedupe because some internal pck upgrade nx bin

---------

Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com>
Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com>
Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>
Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com>
Co-authored-by: Will Ezell <will@dotcms.com>
@manuelrojas
Copy link
Contributor

manuelrojas commented Mar 9, 2023 •
edited

Internal QA Results:

Tested On: dotcms/dotcms:23.03_SNAPSHOT

Video upload shows a warning of not allowing videos bigger than 1mb to be uploaded, however the video can be uploaded

  1. Uploaded a video 32 MB size and no warning were displayed. ✅

Video should fit the size of the container to a maximum size. Currently we are showing the video to full size.

  1. Uploaded a video with 3840×2160 resolution and was displayed correctly. ✅

image

@rjvelazco rjvelazco linked a pull request Mar 16, 2023 that will close this issue
Issue 23863 block editor allow user to insert videos from local files fix size #24374
Merged
fmontes pushed a commit that referenced this issue Mar 17, 2023
@rjvelazco
Fix #23863 block editor allow user to insert videos from local files …
cb5a238 
…fix size (#24374)

* dev: prevent close form while uploading asset #23863

* fix: large videos preview

* clean up

* update block editor

* feedback

* dev: update dotcms-block-editor.js file
@fmontes
Copy link
Member Author

fmontes commented Mar 17, 2023

Kapture.2023-03-17.at.10.23.05.mp4

@wezell
Copy link
Contributor

wezell commented Mar 17, 2023

As part of this card, can you share what the json output of the video block is in its different permutations? @jdcmsd needs it to document.

@fmontes
Copy link
Member Author

fmontes commented Mar 17, 2023

@rjvelazco

Kapture.2023-03-17.at.15.32.56.mp4

rjvelazco added a commit that referenced this issue Mar 20, 2023
@rjvelazco
dev: let user cancel upload #23863
d9273a8
@rjvelazco rjvelazco linked a pull request Mar 21, 2023 that will close this issue
dev: let user cancel upload #23863 #24417
Merged
fmontes pushed a commit that referenced this issue Mar 21, 2023
@rjvelazco
Fix #23863 let user cancel upload (#24417)
96a60fe 
* dev: let user cancel upload #23863

* update dotcms-block-editor.js

* clean up

* feedback

* update dotcms-block-editor.js

* dev: upload automatically after selecting the video
@fmontes
Copy link
Member Author

fmontes commented Mar 21, 2023

Now:

  1. Uploading the video right away during preview
  2. Insert video after upload
  3. Prevent user to close by clicking outside
  4. User can cancel the process by cancel button.

@bryanboza
Copy link
Member

according to the last discussion we need some extra work here:

  • We need to rename the tab DOTCMS by Library
  • We need to support add videos type dotAssets and Files too

Here the video
https://user-images.githubusercontent.com/2641437/227055252-f6454a7e-3a1a-478f-a40a-df6e42b4a77d.mov

rjvelazco added a commit that referenced this issue Mar 23, 2023
@rjvelazco
dev: support video file and dotAsset #23863
a32eee0
@rjvelazco rjvelazco linked a pull request Mar 23, 2023 that will close this issue
Bock Editor: Allow user to insert videos from local files #23863 #24451
Merged
fmontes pushed a commit that referenced this issue Mar 23, 2023
@rjvelazco
Bock Editor: Allow user to insert videos from local files #23863 (#24451
8b0c161 
)

* dev: support video file and dotAsset #23863

* update dotcms-block-editor.js file

* dev: update label to Library and dotcms-block-editor.js file
@fmontes
Copy link
Member Author

fmontes commented Mar 23, 2023

Ok, fix files and add Library to the tab label.

@bryanboza
Copy link
Member

Fixed, tested on release-23.03 // Docker // FF

@rjvelazco rjvelazco mentioned this issue Apr 4, 2023
Closed
erickgonzalez added a commit that referenced this issue May 22, 2023
@erickgonzalez
#23436 #23863 include in 23.01.3
1a8e225
erickgonzalez added a commit that referenced this issue May 22, 2023
@erickgonzalez
#23863 include in 23.01.3
174d563
@erickgonzalez erickgonzalez added LTS: Excluded Ticket that has been excluded from at least one LTS Release : 23.01.3 Included in LTS patch release 23.01.3 labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

Labels
Doc : Needs Doc LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will QA : Approved Release : 23.01.3 Included in LTS patch release 23.01.3 Release : 23.03 Team : Lunik
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
8 participants
@fmontes @wezell @bryanboza @manuelrojas @erickgonzalez @rjvelazco @josemejias07 @damen-dotcms