Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering does not put exact matches on the top of the site dropdown when searching #24921

Closed
damen-dotcms opened this issue May 11, 2023 · 2 comments · Fixed by #25442
Closed

Filtering does not put exact matches on the top of the site dropdown when searching #24921

damen-dotcms opened this issue May 11, 2023 · 2 comments · Fixed by #25442
Assignees
@AndreyDotcms
Labels
dotCMS : Admin Tools LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Customer Support Owned by Scott OKR : User Experience Owned by Jason Priority : 2 High QA : Approved Release : 23.01.8 Included in LTS patch release 23.01.8 Release : 23.08.16 Team : Bug Fixers

Comments

@damen-dotcms
Copy link
Contributor

damen-dotcms commented May 11, 2023 •
edited by swicken-dotcms

Parent Issue

Problem Statement

When you search in the sitesearch dropdown it does not float exact matches to the top. This means it can be impossible to search for an item when it matches against more items than are in the list.

Steps to Reproduce

  1. Create many (20+) sites that have the same text in them (for example example1.test.com, example2.test.com, then just test.com)
  2. Attempt to search for just test.com. This will provide many results, but will not float the exact match (test.com) to the top. If it does not appear on the page at all, then it will never be selectable.

Acceptance Criteria

  1. Exact matches should be at the top of the search results.

dotCMS Version

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Assumptions & Initiation Needs

Quality Assurance Notes & Workarounds

Sub-Tasks & Estimates

Reported by: Scott Wicken (scott.wicken@dotcms.com)

Source URL: https://shsu-prod.dotcms.cloud/dotAdmin/#/c/workflow

Issue details: Open in Marker.io

Device typedesktop
BrowserChrome 112.0.0.0
Screen Size3440 x 1440
OSOS X 13.2.1
Viewport Size1713 x 1162
Zoom Level100%
Pixel Ratio@​1x
@damen-dotcms
Copy link
Contributor Author

Came from Scott.

While it's good we have a wildcard search, we need to have it so that if it's an exact match we put that at the top of the list.

The main site "shsu.edu" is not showing up on the list because the sub-domains all haev "shsu.edu" included in them.

@AndreyDotcms AndreyDotcms self-assigned this Jun 30, 2023
AndreyDotcms added a commit that referenced this issue Jul 7, 2023
@AndreyDotcms
#24921 adding query and working on tests
f99dc7f
AndreyDotcms added a commit that referenced this issue Jul 7, 2023
@AndreyDotcms
#24921 adding query and working on tests
bd2e09e
@AndreyDotcms AndreyDotcms linked a pull request Jul 7, 2023 that will close this issue
Put exact matches on the top of the site dropdown when searching #25442
Merged
3 tasks
AndreyDotcms added a commit that referenced this issue Jul 11, 2023
@AndreyDotcms
#24921 remove unecessarly StringBuilder
2fbd6f1
AndreyDotcms added a commit that referenced this issue Jul 13, 2023
@AndreyDotcms
#24921 adding tests to main suite partitions
8533d74
erickgonzalez pushed a commit that referenced this issue Jul 13, 2023
@AndreyDotcms
Put exact matches on the top of the site dropdown when searching (#25442
c58b410 
)

* #24921 adding query and working on tests

* #24921 adding query and working on tests

* #24921 remove unecessarly StringBuilder

* #24921 adding tests to main suite partitions
@erickgonzalez erickgonzalez reopened this Jul 13, 2023
manuelrojas pushed a commit that referenced this issue Jul 20, 2023
@AndreyDotcms @manuelrojas
Put exact matches on the top of the site dropdown when searching (#25442
eb2b206 
)

* #24921 adding query and working on tests

* #24921 adding query and working on tests

* #24921 remove unecessarly StringBuilder

* #24921 adding tests to main suite partitions
@bryanboza
Copy link
Member

Fixed, now this is working as expected, we are showing the exact match on the top of the list

Image

@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Aug 10, 2023
@erickgonzalez erickgonzalez removed the LTS : Next Ticket that will be added to LTS label Oct 31, 2023
erickgonzalez added a commit that referenced this issue Oct 31, 2023
@erickgonzalez
#24921 include in 23.01.8
bc29980
@erickgonzalez erickgonzalez added Release : 23.01.8 Included in LTS patch release 23.01.8 LTS: Excluded Ticket that has been excluded from at least one LTS and removed Next LTS Release labels Nov 6, 2023
@erickgonzalez erickgonzalez mentioned this issue Jan 26, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreyDotcms AndreyDotcms

Labels
dotCMS : Admin Tools LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Customer Support Owned by Scott OKR : User Experience Owned by Jason Priority : 2 High QA : Approved Release : 23.01.8 Included in LTS patch release 23.01.8 Release : 23.08.16 Team : Bug Fixers
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put exact matches on the top of the site dropdown when searching dotCMS/core
4 participants
@bryanboza @erickgonzalez @damen-dotcms @AndreyDotcms