Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sorting criteria used in the site selector #27447

Closed
2 tasks
nollymar opened this issue Jan 26, 2024 · 6 comments · Fixed by #27497 or #27550
Closed
2 tasks

Change sorting criteria used in the site selector #27447

nollymar opened this issue Jan 26, 2024 · 6 comments · Fixed by #27497 or #27550

Comments

@nollymar
Copy link
Contributor

Parent Issue

No response

User Story

As a user, I want to be able to see the most relevant host at the top of the list if I have a list of similar hosts in the system. For example:

Because we only show 15 hosts, take this case

You have these hosts :

testing1.host.dotcms.com
testing2.host.dotcms.com
testing3.host.dotcms.com
testing4.host.dotcms.com
testing5.host.dotcms.com
testing6.host.dotcms.com
testing7.host.dotcms.com
testing8.host.dotcms.com
testing9.host.dotcms.com
testing11.host.dotcms.com
testing12.host.dotcms.com
testing13.host.dotcms.com
testing14.host.dotcms.com
testing15.host.dotcms.com
testing16.host.dotcms.com
testing17.host.dotcms.com
testing20.host.dotcms.com
host.dotcms.com

And search for: host.dotcms.com

It is possible to NOT get the host.dotcms.com back in your 15 results, pretty much making impossible to ever change to host.dotcms.com.

To fix this problem, we should sort by the shortest. Meaning that if you search for host.dotcms.com it will come back as the top result.

We need to maintain wildcarding on both sides, e.g. like '%host.dotcms.com%'

dupe issue #26615
dupe issue: #26614

Acceptance Criteria

  • Sort by the shortest hostname
  • Wildcard on both sides when searching, e.g. like '%host.dotcms.com%'

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Jan 26, 2024

We fixed this a while ago #24921 but seems that the new changes probably broke it. This was a major issue for customers.

Another scenarios that worth to test are #26980 and #25120

wezell added a commit that referenced this issue Feb 2, 2024
@wezell
Copy link
Contributor

wezell commented Feb 5, 2024

@nollymar this card needs internal QA

@nollymar nollymar self-assigned this Feb 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2024
…n for live+working sites (#27497)

ref: #27447

Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: Nollymar Longa <nollymar.longa@dotcms.com>
@nollymar nollymar reopened this Feb 7, 2024
@nollymar
Copy link
Contributor Author

nollymar commented Feb 8, 2024

Internal QA: Needs Work

The sort criteria when I search is not consistent.
For example:

if I search for host, the site testing1.host.dotcms.com is returned after testing9.host.dotcms.com

Image

but if I search for test, the site testing1.host.dotcms.com is returned before testing2.host.dotcms.com

Image

Screen.Recording.2024-02-08.at.6.52.26.AM.mov

@wezell
Copy link
Contributor

wezell commented Feb 8, 2024

This is what I am seeing

host.testing.mp4

wezell added a commit that referenced this issue Feb 8, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 8, 2024
dsolistorres pushed a commit that referenced this issue Feb 9, 2024
…n for live+working sites (#27497)

ref: #27447

Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: Nollymar Longa <nollymar.longa@dotcms.com>
dsolistorres pushed a commit that referenced this issue Feb 9, 2024
@nollymar
Copy link
Contributor Author

nollymar commented Feb 9, 2024

Internal QA: Passed

@josemejias11
Copy link

Approved: Tested on master_b3b629d, Docker, macOS 13.0, FF v121.0.1

@josemejias11 josemejias11 added the Release : 24.02.20 New binary field, AI plugin label Feb 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 15, 2024
* 🏁 Publishing release version [24.01.26]

* Setting to next version: [1.0.0-SNAPSHOT]

* feat(core): Javascript Scripting API #26227 (#26230)

* #26227 adding js engine + js script actionlet + js resource + js servlet. Still missing the graal real work, but most of the dot-boilerplate is kinda done

* #26227 adding js engine + js script actionlet + js resource + js servlet. Still missing the graal real work, but most of the dot-boilerplate is kinda done

* #26227 adding js engine + js script actionlet + js resource + js servlet. Still missing the graal real work, but most of the dot-boilerplate is kinda done

* #26227 adding js engine + js script actionlet + js resource + js servlet. Still missing the graal real work, but most of the dot-boilerplate is kinda done

* #26227 now at least compiles ok

* #26227 wiring to the dotcms stack

* #26227 seems now is kinda working

* #26227 minor fix

* #26227 adding the ability to print a template or payload return

* #26227 now support a bit the request need to more a lot more to make it ok

* #26227 moving to the dot-mozilla request

* #26227 adding the js request and js context

* #26227 adding the js request and js context

* #26227 adding more elements to the context

* #26227 some more enhacements for response

* #26227 adding changes to handle diff results on the graaljs

* #26277 adding view tools

* #26227 working on proxies and js view tools

* #26227 more proxy

* #26277 the dotcontent js view tool may be done

* #26227 adding the story block map proxy and other fixes

* #26227 more changes to support worfklow on js view tools

* #26227 now the fireEdit is kinda ready to test

* #26227 adding archive

* #26227 addding feedback

* #26227 adding support for all system actions

* #26227 fixes to support wf

* #26227 adding the tags view tool;

* #26227 adding the Tags and template js view tools

* #26227 adding the latest js view tools

* #26227 now the dotcache is working on js

* #26227 adding the fetch

* #26227 adding fetch functionality

* #26227 compiling errors fixed

* #26227 now the sources are being read from the file system and cache the contents in advance

* #26227 now modules are kinda working

* #26227 now user modules are working

* finally cross site modules can be imported

* #26227 adding some fixes

* #26227 adding the last proxies by now

* #26227 adding the content type api

* #26227 adding more changes

* $26227 adding error sintax handling

* #26227 improving the error msg handling

* #26227 adding more error handling

* #26227 now the JSContent is being rendered properly

* #26227 doc and minor improvements

* #26227 adding unit test

* #26227 adding unit test

* #26227 testing the js engine

* #26227 adding test

* #26227 fixing dependencies

* #26227 fixing dependencies

* #26227 fixing unit test

* #26227 fixing test

* #26277 adding feedback

* #26227 sonar feedback

* #26277 sonarq feedback

* #26277 sonarq feedback

* #26277 sonarq feedback

* #26277 sonarq feedback

* #26227 removing temporaly the postman

* #26227 fixing the postman test

* #26227 Adding a change on the postman

* #26227 now if can not read the modules nor functions, just avoid the loading

* #26227 merging with master

* #26227 refactoring the IT

* #26227 feedback done

* #26227 adding sonar feedback

* #26227 sonarq fixes

* #26227 sonarq fixes

* #26227 sonarq fixes

* Fixing label for announcements menu (#27464)

* Added confirm dialog to replace existing asset name on File ContentType (#27466)

* fix(apps): CSS issues #27445 (#27462)

* Solved scroll apps card and avatar on Apps. WIP on scroll issue with textarea

* Fixed css rules

* sec(image) updating imageio libs to latest version (#27021)

ref: #24853

* fix(push-publish): fix view all for bundles in publishing queue (#26170)

* Update dotmarketing-config.properties (#26967)

The `json.web.token.allowhttp` property had its default changed from `true` to `false` about a year ago, but the comment above it was not updated to match; it still seemed to imply a default of `true`, and encouraged users to change it in a production environment. This could lead to confusion, or worse!

Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>

* "#26729 Removing typo in error message" (#27469)

Co-authored-by: NeehaKethi <NeehaKethi@dotcms.com>

* fix(core) #24307 : Fixing problem with Enterprise-only Metadata Providers not loading (#27470)

* Update ApiToken_Resource.postman_collection.json (#26949)

* Update ApiToken_Resource.postman_collection.json

* Update ApiToken_Resource.postman_collection.json

* Update ApiToken_Resource.postman_collection.json

* Update TempAPI.postman_collection.json (#27053)

* fix(CLI): Fixing and ignoring intermittent tests (#27481)

* #26633 Refactor SitePushHandler and add SiteTestHelper

The SitePushHandler class has been refactored to improve readability and maintainability. Helper methods have been introduced to decide whether a site should be published, archived or unpublished. The push handler now utilizes ScheduledExecutorService to handle potential delays in site status changes. Furthermore, SiteTestHelper has been introduced providing common utility functions for site related tests.

* #26633 Refactor site testing and enhance site copying command

Adjusted SiteCommandIT to ensure a site is created before invoking the copy command. The SiteCopy class's output now includes a note that the copy operation happens in the background.

* #26633 Refactor finding site by name into a separate method

* #26633 Handle received exceptions when getting site response

The commit modifies the logic to handle the processing of responses when invoking the verifyAndReturnSiteAfterCompletion method for site pushing. It now makes use of Java's CompletableFuture.exceptionally method, which allows us to handle exceptions that occur in the previous stages of the pipeline. This change also included a minor adjustment to clarify the calculation for ending time in the Runnable task.

* #26633 Disable intermittently failing tests in CLI module

The commit marks a substantial number of tests as disabled due to intermittent failures. These tests span multiple files within the CLI module, across different functionalities such as pulling, pushing, and tree traversal. This temporary measure is taken to enable smoother CI runs, while these intermittent issues are being investigated and resolved.

* #26633 Applying feedback removing Thread.sleep from code

* #27451 Checking if the Experiment is still running before send the Ev… (#27475)

* #27451 Checking if the Experiment is still running before send the Event to Jitsu

* Making sonnar happy

* feat(edit-content): #27289 Allow user to enable a new edit mode from the content types (#27477)

* feat(edit content) #27289 : Add a button to the Content Type screen to enable the new edit mode

* progress

* fix conflicts of cherry picks

* fix tests and add scenarios

* clean up 1

* traductions

* labels fix

* fix conflicts of cherry picks

---------

Co-authored-by: Humberto Morera <humberto.morera@dotcms.com>
Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* chore(core): Expose the `editableAsText` attribute, even if the metadata file doesn't have it yet #27393 (#27398)

* fix(Edit Content) #27393 : Expose the `editableAsText` attribute even if the metadata file doesn't have it yet

* Fixing Integration Test

* Fixing `GraphQLTests.json` Postman Test

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #26800 Adding GITHUB_TOKEN to checkout repo step. (#27495)

* Updating some deprecated action versions.

Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>

* #26900 Allow pass field variables to Monaco's Binary Field And JSON Field (#27388)

* feat(edit-content) add to binary-field and json-field use custom FieldVariable of Monaco Editor

* feat(edit-content) type fixes

* Update core-web/libs/edit-content/src/lib/fields/dot-edit-content-binary-field/components/dot-binary-field-editor/dot-binary-field-editor.component.ts

Make signal private.

Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>

* fix(edit-content) fix comments

* fix(edit-content) add properties to sonarqube config

---------

Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>

* 🏁 Releasing version 1.0.0-SNAPSHOT

* ⬆️  Next version 1.0.0-SNAPSHOT

* chore(edit-ema): Change the nextjs example colors and theme #27425 (#27498)

* chore(edit-ema): Clean up nextjs and app list porlet

* Update clean up

* Clean-up runner (#27504)

* Clean-up runner

* test

* test

* test

* fix(announcements): adjust announcements menu icon size (#27496)

* Adjust icons #27463

* #27463 Fix sizing

* Adding noopener

* feat(Announcements): correcting query that retrieves announcements from prod and fixing postman Ref:s#25736  (#27480)

* #25736 the postman is set to create the CT taking into account the announcementDate as publish date

* #25736 megre latest from master

* #25736 allowing time for publishing to take effect

* #25736 debugging postman failure

* #25736 correcting announcements remote query

* #25736 code clean up

* #25736 updating postman test

* #25736 url query fix

* #25736 adjusting test

* #25736 imrproved IT

* #25736 log should be debug

* chore(core): Update local.dotcms.site cert so that it is valid for 2024 (#27385) doing this in the correct file now #27384 (#27476)

* task(ssl) update local.dotcms.site cert so that it is valid for 2024 (#27385)
doing this in the correct file now.
ref: #27384

* #27384 removing unused/duped tomcat directory

* fix(ui): Fixed scroll on replace-name-dialog in File ContentType (#27509)

* chore(core): Redis Improvements #26932 (#26974)

* #26932 fixes for redis

* #26932 now works locally

* #26932 fixing a test issue

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* use: css variables (#27506)

* feat(edit-content): Implement Key/Value Field #26904 (#27465)

* dev: start refactor

* dev: update DotKeyValueTableInputRow Component

* dev: move DotKeyValue Component to ui library

* dev: rename dot-key-value-ng to dot-key-value

* clean up

* revert: renaming

* dev: fix DotKeyValueTableInputRow Component tests

* dev: cover tests

* dev: cover tests v2

* clean up

* fix: SonarQube Consistency issue

* clean up v2

* test: feedback v1

* dev: feedback v2

* clean up

* fixed checkbox background issue (#27492)

* fix(edit-content): Autocomplete component responsiveness #27421 (#27474)

* fixed expand on tags

* Changed selector on has() for SonarQube bug

* Removed border

* #27479 Adding Vanity URLs (#27515)

* chore(sonar) new sonarqube requires java17 (#27529)

* new sonarqube requires java17

* update the sonarqube client

Change is only in build queue that is currently blocked due to SonarQube issue after upgrade.

* feat(edit content): Add settings to Binary Field content type (#27455)

* create binary settings component

* make the formulary save and delete

* add variables in settings to blacklist

* apply settings to binary field

* Update dot-edit-content-binary-field.component.scss

* change divider color

* add test cases

* clean tests

* add test cases

* add translations

* fix sonarq

* add test cases

* add test cases

* Refactor, make PR suggestions

* Fixed behavior when dont have value

* Fixed getter, missed on merge

* Removed unnecesary code

---------

Co-authored-by: KevinDavilaDotCMS <144152756+KevinDavilaDotCMS@users.noreply.github.com>

* #25736 qa wants postman to fail is we pass an invalid CT (#27520)

* feat(CLI): #27416 Adding GHA release CLI workflow steps for publishing binaries into NPM registry. (#27514)

* #27416 Building NPM package before publishing.

* #27416 Building NPM package before publishing. Testing.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +1.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +2.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +3.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +4.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +5.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +6.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +7.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +8.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +8.

* #27416 Building NPM package before publishing. Testing Jinja2 rendering. +9.

* #27416 Testing build package.

* #27416 Improving artifact composition.

* #27416 Testing package composition.

* #27416 Fixing set up package name and package version.

* #27416 Fixing set up package name and package version. +1.

* #27416 Fixing set up package name and package version. +2.

* #27416 Testing package composition. +1.

* #27416 Fixing package composition.

* #27416 Testing prepare package content step.

* #27416 Some improvements over the CLI release workflow.

* #27416 Generating rc suffix to NPM package  when release SNAPSHOT version.

* #27416 Testing package structure.

* #27416 Checking package.json file configuration.

* #27416 Fixing workflow syntax.

* #27416 Testing assembly configuration.

* #27416 Fixing assembly configuration.

* #27416 Testing assembly configuration. +1.

* #27416 Testing assembly configuration.

* #27416 Some improvements on packaging process.

* #27416 Setting project name into package.json file.

* #27416 Preparing package.json file.

* #27416 Fixing package.json file.

* #27416 Fixing some package composition failures.

* #27416 Workflow commit messages changed.

* #27416 NPM package tagging improvements.

* #27416 Testing package version number resolution.

* #27416 Refactoring NPM_PACKAGE_VERSION resolution.

* #27416 Fixing package version generation.

* #27416 Fixing NPM package version generation.

* #27416 Fixing NPM package version generation. +1.

* #27416 Fixing NPM package version generation. +2.

* #27416 Fixing NPM package version generation. +3.

* #27416 Fixing NPM package version generation. +4.

* #27416 Fixing NPM package version generation. +5.

* #27416 Ready to test the whole process.

* #27416 Uncomment an important instruction for NPM package set up.

* #27416 NPM_PACKAGE_NAME fixed.

---------

Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>

* #27516 fixing the way to capture the inode from an url (#27517)

* #27516 fixing the way to capture the inode from an url

* #27516 adding feedback

* #27516 support other versionable cases

* 🏁 Releasing CLI version 24.01.26

* ⬆️  Next CLI version 1.0.0-SNAPSHOT

* Removing metric code from core (#27485)

* First revert

* second revert

* Reverting Metric changes on core

* Removing

* #27451 Checking if the Experiment is still running before send the Event to Jitsu

* Making sonnar happy

* getting some changes back

* reverting 94fe49b

* fix(hosts) now sorts from shortest to longest.  Also removed a bad join for live+working sites (#27497)

ref: #27447

Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: Nollymar Longa <nollymar.longa@dotcms.com>

* fix(edit-content): Adding multiple binary fields in Content Type breaks the model #27523 (#27533)

* dev: fix registered dojo id error

* dev: fix DotContentletThumbnail Web Component

* clean up

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #27522 Unable to edit content from Card view in content Search (#27524)

* add contentType param + clickable label

* send contentType correctly and update test

* cover event content type and click on thumbnail in table listing

---------

Co-authored-by: Arcadio Quintero <oidacra@gmail.com>

* Fixed autocomplete as dropdown and multiple options (#27532)

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>

* fix(sites) adding secondary sort on hostname, so now sorting sites by shortest, then hostname. (#27550)

ref: #27447

* Update Permission_Resource.postman_collection.json (#26947)

* Update Permission_Resource.postman_collection.json

* Update Permission_Resource.postman_collection.json

* fix(announcements): menu item mark as read (#27548)

* #27494 Implement mark as read

* #27494 Adding announcement test has been read test

* removing space

* Fix test

* chore(security): Upgrading Tomcat to latest minor release 9.0.85 #26722 (#27512)

* sec(core) #26722 : Upgrading Tomcat to latest minor release 9.0.85

* Update server.xml

Removing XML comment from debug process, reported via Code Review.

* need to cleanup runner due to out of disk space (#27566)

* #27453 Include Experience plugin as dependency (#27543)

* #27453 Include Experience plugin as dependency

* feedback

* Update Scripting_Resource.postman_collection.json (#26950)

* Update Scripting_Resource.postman_collection.json

* Update Scripting_Resource.postman_collection.json

* Update Scripting_Resource.postman_collection.json

* Update Scripting_Resource.postman_collection.json

---------

Co-authored-by: Mehdi <10160868+mbiuki@users.noreply.github.com>

* Update BringBack.postman_collection.json (#26948)

* Update BringBack.postman_collection.json

* Update BringBack.postman_collection.json

* Update BringBack.postman_collection.json

* Update BringBack.postman_collection.json

---------

Co-authored-by: Mehdi <10160868+mbiuki@users.noreply.github.com>

* need to run cleanup after checkout (#27567)

* fix(edit-ema): Fixed behaviour on select contentlet (#27560)

---------

Co-authored-by: dotCMS-Machine-User <dotCMS-Machine-User@dotcms.com>
Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Co-authored-by: Kevin Davila <144152756+KevinDavilaDotCMS@users.noreply.github.com>
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: Jamie Mauro <102264829+jdcmsd@users.noreply.github.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
Co-authored-by: Neehakethi-dotcms <139247809+Neehakethi@users.noreply.github.com>
Co-authored-by: NeehaKethi <NeehaKethi@dotcms.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: Rashik Adhikari <128124382+rashik1144@users.noreply.github.com>
Co-authored-by: Jonathan Gamba <jonathan.gamba@dotcms.com>
Co-authored-by: freddyDOTCMS <147462678+freddyDOTCMS@users.noreply.github.com>
Co-authored-by: Humberto Morera <humberto.morera@dotcms.com>
Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
Co-authored-by: Daniel Enrique Colina Rodríguez <danielcolina@gmail.com>
Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>
Co-authored-by: Arcadio Quintero <oidacra@gmail.com>
Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
Co-authored-by: Victor Alfaro <victor.alfaro@dotcms.com>
Co-authored-by: Fabrizzio Araya <37148755+fabrizzio-dotCMS@users.noreply.github.com>
Co-authored-by: spbolton <steve.bolton@dotcms.com>
Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>
Co-authored-by: Nollymar Longa <nollymar.longa@dotcms.com>
Co-authored-by: Humberto Morera <31667212+hmoreras@users.noreply.github.com>
Co-authored-by: Mehdi <10160868+mbiuki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment