-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Punch List : Redis Session Manager #24990
Punch List : Redis Session Manager #24990
Comments
…lized on the simple context instead of the session context
…25179) * Adding/Updating default config values. Using the `SessionMonitor` class to add a Session parameter that indicates the Sessions that must be persisted. * #24990 adding composite context to avoid store the response non-serialized on the simple context instead of the session context * Updating Javadoc and more feedback from Sanchez. * Renaming Session variable, as per feedback form Will. * Reverting incorrect change * Making the `WorkflowSearcher` class implement `Serializable` --------- Co-authored-by: jdotcms <jonathan.sanchez@dotcms.com>
…` class to use the Tomcat Redis Session Manager config as a fallback, if exists. (#25313)
@jcastro-dotcms @bryanboza Not sure how to test this, maybe we send this directly to QA? |
@fmontes I agree. I can pass @bryanboza some instructions on how these improvements can be tested. |
…` class to use the Tomcat Redis Session Manager config as a fallback, if exists. (#25313)
We need to test that we do not put an entry in Redis for single requests. To test clear keys in redis After doing all of this (without logging in) you should be able to run Try logging into the /member page and run |
Fixed, tested on master with the last redis example and now this is working as expected. Some of the tested scenarios
|
Parent Issue
#24294
User Story
DOT_DOTCMS_CLUSTER_ID
is set, use it to prefix all gets/sets/keys/ in REDIS. See our current redis cache implementation. Doing this will allow multiple clusters to share the same session redis store.master
branch totrunk
and make it the default in github.com.dotcms
initializeRedisConnection
. When we start now, it looks like we are configured correctly but then errors happen later once sessions start getting created.TOMCAT_REDIS_ENABLED_FOR_ANON_TRAFFIC
RedisClientFactory
which uses a class calledMasterReplicaLettuceClient
and one in theRedisSessionManager
. In theMasterReplicaLettuceClient
, we can fall back and use the the environmental variables used by theRedisSessionManager
if the ones for theMasterReplicaLettuceClient
are not passed in. We can reuse as many properties from theRedisSessionManager
as possible, including min/maxConnections, SSL, etc...Acceptance Criteria
Finish the punch list.
Proposed Objective
Cloud Engineering
Proposed Priority
Priority 2 - Important
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: