Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Preview Works for All Screen Sizes #25276

Closed
Tracked by #24862
damen-dotcms opened this issue Jun 20, 2023 · 2 comments · Fixed by #25695
Closed
Tracked by #24862

Ensure Preview Works for All Screen Sizes #25276

damen-dotcms opened this issue Jun 20, 2023 · 2 comments · Fixed by #25695
Labels
Merged QA : Approved QA : Passed Internal Release : 23.10.24 Bug-Fixing Team : Scout Type : Task

Comments

@damen-dotcms
Copy link
Contributor

Parent Issue

No response

Task

Currently there is no horizontal scroll when the device is wider than the monitor you are using, so anything wider than the space you have available to edit is clipped off to you.

If a screen preview is wider than the space you have to work with on your current screen, you should see scrollbars.

Proposed Objective

Same as Parent Issue

Proposed Priority

Same as Parent Issue

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@damen-dotcms damen-dotcms mentioned this issue Jun 20, 2023
Closed
1 task
@manuelrojas manuelrojas self-assigned this Jul 24, 2023
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 Adding initial code preview works
4a94475
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 Adding preview updates
04d7f78
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 UI Tweaks
4648d75
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 Refactor code for adding the device
4270b42
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 Refactor icon colors
3aec6f6
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 adding variables
0b5602d
manuelrojas added a commit that referenced this issue Aug 2, 2023
@manuelrojas
#25276 Fixing variables
d911294
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 adding toolbar sizes
ad63b96
@manuelrojas manuelrojas linked a pull request Aug 3, 2023 that will close this issue
[Issue-25276]: Ensure preview works for all screen sizes #25695
Merged
3 tasks
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Code refactor for the new menu
599efcf
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 refactor tab buttons components
2300eb3
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Adding initial code preview works
cf1f556
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Adding preview updates
0f02c07
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 UI Tweaks
72a4463
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Refactor code for adding the device
cbaff1a
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Refactor icon colors
da3ed64
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 adding variables
1a81adc
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Fixing variables
a64ca76
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Code refactor for the new menu
9feffb5
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 refactor tab buttons components
163a084
manuelrojas added a commit that referenced this issue Aug 3, 2023
@manuelrojas
#25276 Adding testing components
bccfc0b
manuelrojas added a commit that referenced this issue Aug 4, 2023
@manuelrojas
#25276 Fixing tests after the component update
999fa84
manuelrojas added a commit that referenced this issue Aug 4, 2023
@manuelrojas
#25276 Fixing latest tests
0256aa8
manuelrojas added a commit that referenced this issue Aug 4, 2023
@manuelrojas
#25276 Fixing variables
6a6cb0e
manuelrojas added a commit that referenced this issue Aug 4, 2023
@manuelrojas
#25276 Adding better names
196ccd2
manuelrojas added a commit that referenced this issue Aug 4, 2023
@manuelrojas
#25276 Adding more coverage
9f0d149
manuelrojas added a commit that referenced this issue Aug 4, 2023
@manuelrojas
#25276 Adding more coverage
72dbee0
manuelrojas added a commit that referenced this issue Aug 7, 2023
@manuelrojas
#25276 PR feedback
abee858
manuelrojas added a commit that referenced this issue Aug 7, 2023
@manuelrojas
#25276 PR feedback
ac6bbdc
nollymar pushed a commit that referenced this issue Aug 7, 2023
@manuelrojas
[Issue-25276]: Ensure preview works for all screen sizes (#25695)
8d05e1d 
* #25276 Adding initial code preview works

* #25276 Adding preview updates

* #25276 UI Tweaks

* #25276 Refactor code for adding the device

* #25276 Refactor icon colors

* #25276 adding variables

* #25276 Fixing variables

* Merging with master

* #25276 Code refactor for the new menu

* #25276 refactor tab buttons components

* #25276 Adding testing components

* #25276 Fixing tests after the component update

* #25276 Fixing latest tests

* #25276 Fixing variables

* #25276 Adding better names

* #25276 Adding more coverage

* #25276 Adding more coverage

* #25276 PR feedback

* #25276 PR feedback

* Fixing test

* Adding PR feedback
@nollymar nollymar reopened this Aug 7, 2023
@dcolina dcolina self-assigned this Aug 8, 2023
@dcolina
Copy link
Contributor

dcolina commented Aug 8, 2023

Internal QA: PASSED

As you can see below.

Screen.Recording.2023-08-08.at.19.30.12.mov

@dcolina dcolina removed their assignment Aug 8, 2023
@josemejias11
Copy link

Approved: Tested on master_839d283_SNAPSHOT, Docker, macOS 13.0, FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Approved QA : Passed Internal Release : 23.10.24 Bug-Fixing Team : Scout Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue-25276]: Ensure preview works for all screen sizes dotCMS/core
5 participants
@manuelrojas @nollymar @dcolina @damen-dotcms @josemejias11