[Issue-25276]: Ensure preview works for all screen sizes #25695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelrojas
force-pushed
the
issue-25276-ensure-preview-works-for-all-screen-sizes
branch
from
2300eb3
to
163a084
Compare
manuelrojas
requested review from
zJaaal,
rjvelazco,
oidacra,
hmoreras and
nollymar
zJaaal
reviewed
Aug 4, 2023
core-web/apps/dotcms-ui/src/app/portlets/dot-edit-page/content/dot-edit-content.component.scss
Outdated
Show resolved
Hide resolved
zJaaal
reviewed
Aug 4, 2023
...dit-page/seo/components/dot-device-selector-seo/dot-device-selector-seo.component.stories.ts
Outdated
Show resolved
Hide resolved
zJaaal
reviewed
Aug 4, 2023
...p/portlets/dot-edit-page/seo/components/dot-page-tools-seo/dot-page-tools-seo.component.scss
Outdated
Show resolved
Hide resolved
zJaaal
reviewed
Aug 4, 2023
rjvelazco
reviewed
Aug 4, 2023
core-web/apps/dotcms-ui/src/app/portlets/dot-edit-page/content/dot-edit-content.component.scss
Outdated
Show resolved
Hide resolved
...t-edit-page/seo/components/dot-device-selector-seo/dot-device-selector-seo.component.spec.ts
Outdated
Show resolved
Hide resolved
...ents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.spec.ts
Show resolved
Hide resolved
...nts/dot-edit-page-view-as-controller-seo/dot-edit-page-view-as-controller-seo.component.html
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.spec.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
oidacra
reviewed
Aug 4, 2023
core-web/libs/ui/src/lib/dot-tab-buttons/dot-tab-buttons.component.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Aug 4, 2023
...ts/dot-edit-page/seo/components/dot-device-selector-seo/dot-device-selector-seo.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Aug 7, 2023
hmoreras
reviewed
Aug 7, 2023
...ponents/dot-edit-page-state-controller-seo/dot-edit-page-state-controller-seo.component.html
Outdated
Show resolved
Hide resolved
hmoreras
approved these changes
Aug 7, 2023
rjvelazco
approved these changes
Aug 7, 2023
|
SonarQube Quality Gate
|
nollymar
approved these changes
Aug 7, 2023
nollymar
deleted the
issue-25276-ensure-preview-works-for-all-screen-sizes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
🤖 Generated by Copilot at 72dbee0
This pull request implements a new design and functionality for the edit page toolbar, which includes a device selector feature. It adds a
dot-tab-buttonscomponent to the dotcms/ui library, which provides a tabbed interface for the edit and preview modes, and a dropdown icon to open the device selector menu. It updates thedot-device-selector-seocomponent to use theOverlayPanelcomponent from the primeng library, and to improve its appearance and number formatting. It also updates thedot-page-state.serviceto pass the device information from the view as options to the page state. It modifies several files in the dot-edit-page module to use the new components and styles, and to move the what's changed checkbox to the view as controller component. It adds and updates some tests and stories for the new and modified components. It removes some unused variables from the _variables.scss file. It fixes a bug that prevented scrolling inside the iframe in the edit mode.Checklist
Additional Info
** any additional useful context or info **
Screenshots
Screen.Recording.2023-08-04.at.10.52.42.mov