Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor Image Component Improvement #25580

Closed
2 tasks
wezell opened this issue Jul 20, 2023 · 3 comments · Fixed by #25642
Closed
2 tasks

Block Editor Image Component Improvement #25580

wezell opened this issue Jul 20, 2023 · 3 comments · Fixed by #25642

Comments

@wezell
Copy link
Contributor

wezell commented Jul 20, 2023

Parent Issue

No response

User Story

When I select an image using the block editor, it does not look "selected". We should add a border or something around the image to show that the image is selected.

Also, there is no visible way to delete an image once you have added it - we should probably add a trash can icon to the properties bar that will remove the image if you click it.

Other ideas - do we want to allow an image to be resized? Take a look at our wysiwyg and how it allows an image to be resized inline. It just stores the resize as another property in the block that can be used or ignored.

Acceptance Criteria

  • Add a blue? border around an image once you have selected it.
  • Add a trash can icon to the properties bar that will delete the image.

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@fmontes
Copy link
Member

fmontes commented Jul 26, 2023

Important test with:

dotAssets and external images

@zJaaal zJaaal self-assigned this Jul 26, 2023
@zJaaal zJaaal linked a pull request Jul 27, 2023 that will close this issue
fmontes pushed a commit that referenced this issue Aug 2, 2023
* add delete button to image node

* add padding and border to image focus

* compile block editor

* fix styles for selected image

* Update dotcms-block-editor.js
@rjvelazco rjvelazco self-assigned this Aug 4, 2023
@rjvelazco
Copy link
Contributor

Passed Internal QA

Docker Image: [dotcms/dotcms:master_524e70e]

Screen.Recording.2023-08-04.at.11.56.02.AM.mov

@josemejias11
Copy link

Approved QA - Tested on master_a07a969_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants