Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25580: Block Editor Image Component Improvement #25642

Merged
merged 15 commits into from Aug 2, 2023

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Jul 27, 2023

🤖 Generated by Copilot at 7411cd2

Summary

🖼️🎨🗑️

Added image editing functionality to the dot-block-editor component. Users can now select, delete, and modify images using the bubble menu and the core-web library.

dot-block-editor
Image nodes get new features
Autumn of updates

Walkthrough

  • Add padding and border to selected image node in dot-block-editor component to improve spacing and visibility (link)
  • Add delete option to bubble menu for image nodes with trash icon and deleteNode action (link)

Screenshots

Original

Screenshot 2023-07-27 at 10 31 22 AM

Updated

Screenshot 2023-07-27 at 10 29 23 AM

@zJaaal zJaaal linked an issue Jul 27, 2023 that may be closed by this pull request
2 tasks
@zJaaal zJaaal requested a review from a team July 27, 2023 13:32
@fmontes
Copy link
Member

fmontes commented Jul 28, 2023

@zJaaal We have to fix conflicts here.

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmontes fmontes merged commit d0a4af2 into master Aug 2, 2023
26 of 34 checks passed
@fmontes fmontes deleted the issue-25580-block-editor-image-component-improvement branch August 2, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Editor Image Component Improvement
4 participants