Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve logging handling #25721

Closed
nollymar opened this issue Aug 8, 2023 · 3 comments · Fixed by #25858 or #26010
Closed

CLI: Improve logging handling #25721

nollymar opened this issue Aug 8, 2023 · 3 comments · Fixed by #25858 or #26010

Comments

@nollymar
Copy link
Contributor

nollymar commented Aug 8, 2023

Parent Issue

No response

Task

We should include a proper implementation to handle logging in the CLI. For this, it is important to check out the library used by Quarkus (probably JBoss logging)

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@jgambarios jgambarios self-assigned this Aug 16, 2023
jgambarios added a commit that referenced this issue Aug 21, 2023
…en updated to improve overall logging efficiency.
jgambarios added a commit that referenced this issue Aug 21, 2023
…en updated to improve overall logging efficiency.
jgambarios added a commit that referenced this issue Aug 21, 2023
…en updated to improve overall logging efficiency.
jgambarios added a commit that referenced this issue Aug 21, 2023
…en updated to improve overall logging efficiency.
jgambarios added a commit that referenced this issue Aug 22, 2023
A new class, `LoggingExecutionStrategy`, has been added to the project. This class implements `IExecutionStrategy` with the added functionality to log the command being executed. It is used in `EntryCommand` class to wrap the existing execution strategy, allowing us to log the commands entered by users in the command-line interface. This helps in debugging by providing a clearer picture of the sequence of commands executed.
jgambarios added a commit that referenced this issue Aug 22, 2023
@jgambarios
Copy link
Contributor

PR: #25858

@nollymar nollymar linked a pull request Aug 24, 2023 that will close this issue
nollymar pushed a commit that referenced this issue Aug 24, 2023
* #25721 Logging configurations in application.properties files have been updated to improve overall logging efficiency.

* #25721 Logging configurations in application.properties files have been updated to improve overall logging efficiency.

* #25721 Logging configurations in application.properties files have been updated to improve overall logging efficiency.

* #25721 Logging configurations in application.properties files have been updated to improve overall logging efficiency.

* #25721 Add logging for executed commands

A new class, `LoggingExecutionStrategy`, has been added to the project. This class implements `IExecutionStrategy` with the added functionality to log the command being executed. It is used in `EntryCommand` class to wrap the existing execution strategy, allowing us to log the commands entered by users in the command-line interface. This helps in debugging by providing a clearer picture of the sequence of commands executed.

* #25721 Updating documentation
@nollymar nollymar reopened this Aug 24, 2023
jgambarios added a commit that referenced this issue Sep 6, 2023
Modified README.md to provide clearer instructions on how to manipulate log levels when debugging. Also added details on how to change the default log file location, giving users more control and flexibility. The changes aim to assist users in developing and debugging issues in an efficient manner.
@nollymar nollymar linked a pull request Sep 6, 2023 that will close this issue
nollymar pushed a commit that referenced this issue Sep 6, 2023
Modified README.md to provide clearer instructions on how to manipulate log levels when debugging. Also added details on how to change the default log file location, giving users more control and flexibility. The changes aim to assist users in developing and debugging issues in an efficient manner.
@nollymar nollymar reopened this Sep 6, 2023
@jgambarios
Copy link
Contributor

Note to QA: The documentation related to this task can be found under https://github.com/dotCMS/core/blob/master/tools/dotcms-cli/README.md#logging

@nollymar
Copy link
Contributor Author

nollymar commented Sep 8, 2023

Internal QA: passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants