Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of comments in Task details modal. #25729

Closed
EdgarPsda opened this issue Aug 8, 2023 · 5 comments · Fixed by #27129 or #27190
Closed

Order of comments in Task details modal. #25729

EdgarPsda opened this issue Aug 8, 2023 · 5 comments · Fixed by #27129 or #27190
Assignees
@AndreyDotcms
Labels
OKR : Customer Support Owned by Scott Priority : 4 Low QA : Approved Release : 23.01.14 Included in LTS patch release 23.01.14 Release : 23.10.24 v7 Included in LTS patch release 23.10.24 v7 Release : 24.01.26 Bug Fixing Team : Bug Fixers Type : Defect

Comments

@EdgarPsda
Copy link

Parent Issue

No response

Problem Statement

When a Task (details modal), The list of comments is ordered the old one first; Ideally is the newest first.,

Steps to Reproduce

1.- Go to Dashboard -> Task.
2.- Open any task details (modal).
3.- The list of comments is ordered from oldest to newest.

Screenshot 2023-08-08 at 11 45 50 AM

Acceptance Criteria

The list of comments should be the newest first.

dotCMS Version

21.06

Proposed Objective

Core Features

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/112830

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 7, 2023
@Neehakethi
Copy link
Contributor

https://dotcms.zendesk.com/agent/tickets/114161

@AndreyDotcms AndreyDotcms self-assigned this Dec 27, 2023
AndreyDotcms added a commit that referenced this issue Dec 28, 2023
@AndreyDotcms
#25729 adding test and removing unnecessary sort
9d24e4d
@AndreyDotcms AndreyDotcms linked a pull request Dec 28, 2023 that will close this issue
The list of comments is in the correct order #27129
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 2, 2024
@AndreyDotcms
#25729 adding test and removing unnecessary sort (#27129)
e897d2b
@erickgonzalez erickgonzalez reopened this Jan 2, 2024
@erickgonzalez
Copy link
Contributor

Needs Work:

New comments are set on top, which is good, but previous comments are still sorted from oldest to newest.
Screenshot 2024-01-03 at 3 31 36 PM

STR:
1- Create a new content
2- Save and Publish
3- Unpublish the content
4- Go to Tasks Portlet
5- Open the created content

AndreyDotcms added a commit that referenced this issue Jan 5, 2024
@AndreyDotcms
#25729 adding desc order to list
8ebb9bb
@AndreyDotcms AndreyDotcms linked a pull request Jan 5, 2024 that will close this issue
desc sort order when merge list #27190
Merged
AndreyDotcms added a commit that referenced this issue Jan 5, 2024
@AndreyDotcms
#25729 feedback
e2dbcfe
AndreyDotcms added a commit that referenced this issue Jan 5, 2024
@AndreyDotcms
#25729 adding final
999bc64
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
@AndreyDotcms @erickgonzalez
desc sort order when merge list (#27190)
e36d2a7 
* #25729 adding test and removing unnecessary sort

* #25729 adding desc order to list

* #25729 feedback

* #25729 adding final

---------

Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@erickgonzalez erickgonzalez reopened this Jan 8, 2024
@erickgonzalez
Copy link
Contributor

Working as it should new and old comments are sorted from newest to oldest.

Screenshot 2024-01-17 at 8 13 31 AM

@josemejias11
Copy link

Approved: Tested on master_8aae521, Docker, macOS 13.0, FF v121.0.1

@erickgonzalez erickgonzalez added LTS : Next Ticket that will be added to LTS Priority : 4 Low labels Jan 20, 2024
@erickgonzalez erickgonzalez added Next LTS Release LTS : Next Ticket that will be added to LTS and removed LTS : Next Ticket that will be added to LTS Next LTS Release labels Feb 16, 2024
@erickgonzalez erickgonzalez mentioned this issue Mar 4, 2024
Closed
@erickgonzalez erickgonzalez added Next LTS Release Shortlisted of issues that will be included in the upcoming LTS and removed LTS : Next Ticket that will be added to LTS labels Mar 6, 2024
erickgonzalez added a commit that referenced this issue Mar 14, 2024
@erickgonzalez
#25729 include in 23.01.14
0f77710
erickgonzalez added a commit that referenced this issue Mar 22, 2024
@erickgonzalez
#25729 include in 23.10.24
559beaf
@erickgonzalez erickgonzalez added Release : 23.10.24 v7 Included in LTS patch release 23.10.24 v7 Release : 23.01.14 Included in LTS patch release 23.01.14 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreyDotcms AndreyDotcms

Labels
OKR : Customer Support Owned by Scott Priority : 4 Low QA : Approved Release : 23.01.14 Included in LTS patch release 23.01.14 Release : 23.10.24 v7 Included in LTS patch release 23.10.24 v7 Release : 24.01.26 Bug Fixing Team : Bug Fixers Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
5 participants
@erickgonzalez @EdgarPsda @AndreyDotcms @josemejias11 @Neehakethi