Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Containers]: Fix Container Content Types Variable List Showing Rows and Columns #26180

Closed
fmontes opened this issue Sep 19, 2023 · 3 comments · Fixed by #26196 or #26286
Closed

[Containers]: Fix Container Content Types Variable List Showing Rows and Columns #26180

fmontes opened this issue Sep 19, 2023 · 3 comments · Fixed by #26196 or #26286
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Sep 19, 2023 •
edited

Problem Statement

When creating or editing a container content type, the variable list is showing rows and columns, which should not happen.

Steps to Reproduce

Kapture.2023-09-19.at.15.18.08.mp4

Acceptance Criteria

  • Filter the list of variables to not include rows and/or columns
  • Confirm with the old portlet

External Links

N/A

Assumptions & Initiation Needs

  • Assume that the variable list should not show rows and columns when creating or editing a container content type
  • No initiation needs

Quality Assurance Notes & Workarounds

  • Test by creating or editing a container content type to ensure that the variable list does not show rows and columns
  • No workarounds available
@fmontes fmontes linked a pull request Sep 25, 2023 that will close this issue
Filtered Rows and Columns in variables list #26196
Merged
@fmontes
Copy link
Member Author

fmontes commented Sep 25, 2023

Kapture.2023-09-25.at.11.55.05.mp4

@rjvelazco rjvelazco linked a pull request Sep 27, 2023 that will close this issue
Fix/26180 homologate variable list #26286
Merged
fmontes pushed a commit that referenced this issue Sep 27, 2023
@KevinDavilaDotCMS
fix(containers) #26180 [Containers] Content Types Variable List Showi…
d462cb3 
…ng Rows and Columns #26180

* Added 'Content Identifier Value' to Variable List

* Added test to new variable 'Content Identifier Value'

* Added data-testId and new spec

* Added DotMessage logic to variable label. Modified test to cover the new DotMessage logic

* Changed DotMessagePipe to DotMessageService, to use directly the logic on service
@fmontes
Copy link
Member Author

fmontes commented Oct 2, 2023

There is more work to be done in the variables and we have a ticket for that: #26293

@josemejias11
Copy link

Approved: Tested on master_d0f3abe_SNAPSHOT, Docker, macOS 13.0, FF v113.0
Screenshot 2023-10-02 at 2 37 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
3 participants
@fmontes @josemejias11 @KevinDavilaDotCMS