Filtered Rows and Columns in variables list #26196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
reviewed
Sep 20, 2023
| (variable) => variable.fieldType !== 'Column' && variable.fieldType !== 'Row' | ||
| ); | ||
|
|
||
| return { variables: variables }; |
zJaaal
reviewed
Sep 20, 2023
| vm$ = this.store.vm$.pipe( | ||
| map((res) => { | ||
| const variables = res.variables.filter( | ||
| (variable) => variable.fieldType !== 'Column' && variable.fieldType !== 'Row' |
There was a problem hiding this comment.
I wonder if we should do an enum for Column/Row
There was a problem hiding this comment.
Also, can we add a test for this filter?
zJaaal
requested changes
Sep 20, 2023
| vm$ = this.store.vm$.pipe( | ||
| map((res) => { | ||
| const variables = res.variables.filter( | ||
| (variable) => variable.fieldType !== 'Column' && variable.fieldType !== 'Row' |
There was a problem hiding this comment.
Also, can we add a test for this filter?
fmontes
requested changes
Sep 21, 2023
| vm$ = this.store.vm$.pipe( | ||
| map((res) => { | ||
| const variables = res.variables.filter( | ||
| (variable) => variable.fieldType !== 'Column' && variable.fieldType !== 'Row' |
| (variable) => variable.fieldType !== 'Column' && variable.fieldType !== 'Row' | ||
| ); | ||
|
|
||
| return { variables: variables }; |
rjvelazco
requested changes
Sep 21, 2023
|
SonarQube Quality Gate
|
fmontes
approved these changes
Sep 22, 2023
zJaaal
approved these changes
Sep 25, 2023
rjvelazco
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 07b0f3a
Summary
🗺️🚰📝
Improved container code editor to allow filtering variables by
fieldType. Modifieddot-add-variable.component.tsto usemapoperator for filtering.Walkthrough
mapoperator fromrxjsto transform the store data (link)Additional Info
** any additional useful context or info **
Screenshots