Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteSelector not showing all possible sites for limited user #26980

Closed
erickgonzalez opened this issue Dec 12, 2023 · 1 comment · Fixed by #26981
Closed

SiteSelector not showing all possible sites for limited user #26980

erickgonzalez opened this issue Dec 12, 2023 · 1 comment · Fixed by #26981
Assignees
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS QA : Approved Release : 23.01.10 Included in LTS patch release 23.01.10 Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect

Comments

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Dec 12, 2023

Parent Issue

No response

Problem Statement

When a limited user has permissions for specific sites, not all these sites show up in the site selector.

Steps to Reproduce

1- Create 17 new sites.
2- Create a New User.
3- Create a New Role and Assign to this user.
4- Assign the Browser Portlet to this role.
5- Give permission to the first and last created site.
6- Login as the limited user.
7- Site Selector doesn't show up all possible sites.

Acceptance Criteria

It should show all sites for which the limited user has permission (limited to 15).

dotCMS Version

23.01+

Proposed Objective

Customer Success

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/114515

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@erickgonzalez erickgonzalez self-assigned this Dec 12, 2023
erickgonzalez added a commit that referenced this issue Dec 12, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2023
* fix: recursively call search site for limited user ref: #26980

* chore: trim list if over the limit ref: #26980
@erickgonzalez erickgonzalez reopened this Dec 13, 2023
@bryanboza
Copy link
Member

Fixed, tested on master and now we are able to see the sites in the site selector when you have the respective permissions as a limited user

Image

@erickgonzalez erickgonzalez added LTS : Next Ticket that will be added to LTS Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 and removed OKR : Customer Success Owned by Arno labels Dec 18, 2023
@bryanboza bryanboza added Release : 23.12.21 SEO Improvements and removed Release 23.12.21 labels Dec 22, 2023
@erickgonzalez erickgonzalez added Next LTS Release and removed LTS : Next Ticket that will be added to LTS labels Dec 27, 2023
erickgonzalez added a commit that referenced this issue Dec 28, 2023
@erickgonzalez erickgonzalez added Release : 23.01.10 Included in LTS patch release 23.01.10 LTS: Excluded Ticket that has been excluded from at least one LTS and removed Next LTS Release labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS QA : Approved Release : 23.01.10 Included in LTS patch release 23.01.10 Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants