Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiments result dates in chart dates are incorrect by one day. #27063

Closed
hmoreras opened this issue Dec 19, 2023 · 2 comments · Fixed by #27079
Closed

Experiments result dates in chart dates are incorrect by one day. #27063

hmoreras opened this issue Dec 19, 2023 · 2 comments · Fixed by #27079
Labels
dotCMS : Experiments Analytics Umbrella: Experiments Feature Experiments LTS Issues Related to Experiments that we need in LTS LTS: Excluded Ticket that has been excluded from at least one LTS Merged QA : Approved QA : Passed Internal Release : 23.10.24 v2 Included in LTS patch release 23.10.24 v2 Release : 24.01.26 Bug Fixing Team : Falcon Type : Defect

Comments

@hmoreras
Copy link
Contributor

hmoreras commented Dec 19, 2023 •
edited
Loading

Parent Issue

No response

Problem Statement

Experiments result dates in chart dates are incorrect by one day. The date range start a day before the first result, that is correct, but the last day is one less that is should.

Steps to Reproduce

generate experiment results, and check the last day. is one day before the give data.

given this:

"details": { "2023-12-11": { "conversionRate": 88.89, "totalSessions": 9, "uniqueBySession": 8 }, "2023-12-12": { "conversionRate": 0, "totalSessions": 0, "uniqueBySession": 0 }, "2023-12-18": { "conversionRate": 0, "totalSessions": 1, "uniqueBySession": 0 } }

generate:
Screenshot 2023-12-18 at 10 30 47 AM

December 18th is missing.

Acceptance Criteria

chart should reflect what comes from the endpoint.

dotCMS Version

latest

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@hmoreras hmoreras self-assigned this Dec 19, 2023
@hmoreras hmoreras linked a pull request Dec 20, 2023 that will close this issue
dotCMS/core#27063 Experiments result dates in chart dates are incorrect by one day. #27079
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 20, 2023
@hmoreras
#27063 Experiments result dates in chart dates are incorrect by one d…
3c8b5e0 
…ay. (#27079)

* fix

* clean up

* feedback - constant
@hmoreras hmoreras reopened this Dec 20, 2023
@hmoreras hmoreras removed their assignment Dec 20, 2023
@freddyDOTCMS freddyDOTCMS self-assigned this Dec 26, 2023
@freddyDOTCMS
Copy link
Contributor

Pass Internal QA: Work as expected

@freddyDOTCMS freddyDOTCMS removed their assignment Dec 26, 2023
@dsilvam dsilvam added the Experiments LTS Issues Related to Experiments that we need in LTS label Jan 2, 2024
@bryanboza
Copy link
Member

Fixed, tested on master // Docker // FF

@erickgonzalez erickgonzalez added the LTS: Excluded Ticket that has been excluded from at least one LTS label Jan 4, 2024
erickgonzalez added a commit that referenced this issue Jan 8, 2024
@erickgonzalez
#27063 include in 23.10.24
e49d3fe
@erickgonzalez erickgonzalez added the Release : 23.10.24 v2 Included in LTS patch release 23.10.24 v2 label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : Experiments Analytics Umbrella: Experiments Feature Experiments LTS Issues Related to Experiments that we need in LTS LTS: Excluded Ticket that has been excluded from at least one LTS Merged QA : Approved QA : Passed Internal Release : 23.10.24 v2 Included in LTS patch release 23.10.24 v2 Release : 24.01.26 Bug Fixing Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dotCMS/core#27063 Experiments result dates in chart dates are incorrect by one day. dotCMS/core
6 participants
@dsilvam @bryanboza @erickgonzalez @hmoreras @damen-dotcms @freddyDOTCMS